Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 876933005: Replace SkProxyCanvas with SkNWayCanvas. (Closed)

Created:
5 years, 10 months ago by scroggo
Modified:
5 years, 10 months ago
Reviewers:
fmalita1, f(malita), reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace SkProxyCanvas with SkNWayCanvas. We are removing SkProxyCanvas, which is a subset of SkNWayCanvas. BUG=skia:3279 Committed: https://crrev.com/f3b7c52abef600ea38edfc12ab167f4e33c33811 Cr-Commit-Position: refs/heads/master@{#313751}

Patch Set 1 #

Patch Set 2 : Call superclass constructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M skia/ext/benchmarking_canvas.cc View 1 12 chunks +27 lines, -26 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
scroggo
5 years, 10 months ago (2015-01-29 14:39:31 UTC) #2
reed1
lgtm
5 years, 10 months ago (2015-01-29 15:54:36 UTC) #3
scroggo
Florin, will you please review? I think I need some more types of approval before ...
5 years, 10 months ago (2015-01-29 16:47:15 UTC) #5
f(malita)
lgtm
5 years, 10 months ago (2015-01-29 17:38:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876933005/1
5 years, 10 months ago (2015-01-29 17:39:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/37531)
5 years, 10 months ago (2015-01-29 17:46:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876933005/20001
5 years, 10 months ago (2015-01-29 18:14:41 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 19:10:46 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 19:12:06 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3b7c52abef600ea38edfc12ab167f4e33c33811
Cr-Commit-Position: refs/heads/master@{#313751}

Powered by Google App Engine
This is Rietveld 408576698