Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
876933004:
Fix indirect use of defined() directive (Closed)
|
Created:
5 years, 10 months ago by Tom Hudson Modified:
5 years, 6 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionFix indirect use of defined() directive
BUG=432391
R=bsalomon,bungeman1
Committed: https://skia.googlesource.com/skia/+/3fef728e16cc1e21c743be28708d0104a9481de8
Patch Set 1 #
Messages
Total messages: 21 (8 generated)
bungeman@google.com changed reviewers: + bungeman@google.com - bungeman@gmail.com
lgtm
The CQ bit was checked by bungeman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876933004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bungeman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876933004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
On 2015/06/22 14:27:53, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, > http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...) Yeah, forgot this was in include/ . bsalomon will have to look at it.
On 2015/06/22 14:34:29, bungeman1 wrote: > Yeah, forgot this was in include/ . bsalomon will have to look at it. Yep, thanks for realizing this had fallen off everybody's radars. He's out, and the other API owners are on airplanes, but having waited since February it can probably wait until he's back in tomorrow.
reed@google.com changed reviewers: + reed@google.com
if robert or jvanverth are cool w/ this, I'm cool.
bungeman@google.com changed reviewers: + jvanverth@google.com, robertphillips@google.com
See reed1's comment.
lgtm
lgtm, too
The CQ bit was checked by bsalomon@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876933004/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/3fef728e16cc1e21c743be28708d0104a9481de8 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
