Refactored to make MDnsSocketFactory return array of sockets.

chrome/utility/local_discovery/local_domain_resolver_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/utility/local_discovery/service_discovery_client_impl.h"
 #include "net/dns/mdns_client_impl.h"
 #include "net/dns/mock_mdns_socket_factory.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 42 matching lines @@
   0x00, 0x10,
   0x00, 0x10,        // RDLENGTH is 4 bytes.
   0x00, 0x0A, 0x00, 0x00,
   0x00, 0x00, 0x00, 0x00,
   0x00, 0x01, 0x00, 0x02,
   0x00, 0x03, 0x00, 0x04,
 };
 
 class LocalDomainResolverTest : public testing::Test {
  public:
-  LocalDomainResolverTest() : socket_factory_(new net::MockMDnsSocketFactory),
-    mdns_client_(
-        scoped_ptr<net::MDnsConnection::SocketFactory>(
-            socket_factory_)) {
-  }
-
-  ~LocalDomainResolverTest() {
-  }
-
   virtual void SetUp() OVERRIDE {
-    mdns_client_.StartListening();
+    mdns_client_.StartListening(&socket_factory_);
   }
 
   std::string IPAddressToStringWithEmpty(const net::IPAddressNumber& address) {
     if (address.empty()) return "";
     return net::IPAddressToString(address);
   }
 
   void AddressCallback(bool resolved,
                        const net::IPAddressNumber& address_ipv4,
                        const net::IPAddressNumber& address_ipv6) {
@@ skipping 11 matching lines @@
 
     base::MessageLoop::current()->Run();
     callback.Cancel();
   }
 
   MOCK_METHOD3(AddressCallbackInternal,
                void(bool resolved,
                     std::string address_ipv4,
                     std::string address_ipv6));
 
-  net::MockMDnsSocketFactory* socket_factory_;
+  net::MockMDnsSocketFactory socket_factory_;
   net::MDnsClientImpl mdns_client_;
   base::MessageLoop message_loop_;
 };
 
 TEST_F(LocalDomainResolverTest, ResolveDomainA) {
   LocalDomainResolverImpl resolver(
       "myhello.local", net::ADDRESS_FAMILY_IPV4,
       base::Bind(&LocalDomainResolverTest::AddressCallback,
                  base::Unretained(this)), &mdns_client_);
 
-  EXPECT_CALL(*socket_factory_, OnSendTo(_))
-      .Times(2);  // Twice per query
+  EXPECT_CALL(socket_factory_, OnSendTo(_)).Times(2);  // Twice per query
 
   resolver.Start();
 
   EXPECT_CALL(*this, AddressCallbackInternal(true, "1.2.3.4", ""));
 
-  socket_factory_->SimulateReceive(
-      kSamplePacketA, sizeof(kSamplePacketA));
+  socket_factory_.SimulateReceive(kSamplePacketA, sizeof(kSamplePacketA));
 }
 
 TEST_F(LocalDomainResolverTest, ResolveDomainAAAA) {
   LocalDomainResolverImpl resolver(
       "myhello.local", net::ADDRESS_FAMILY_IPV6,
       base::Bind(&LocalDomainResolverTest::AddressCallback,
                  base::Unretained(this)), &mdns_client_);
 
-  EXPECT_CALL(*socket_factory_, OnSendTo(_))
-      .Times(2);  // Twice per query
+  EXPECT_CALL(socket_factory_, OnSendTo(_)).Times(2);  // Twice per query
 
   resolver.Start();
 
   EXPECT_CALL(*this, AddressCallbackInternal(true, "", "a::1:2:3:4"));
 
-  socket_factory_->SimulateReceive(
-      kSamplePacketAAAA, sizeof(kSamplePacketAAAA));
+  socket_factory_.SimulateReceive(kSamplePacketAAAA, sizeof(kSamplePacketAAAA));
 }
 
 TEST_F(LocalDomainResolverTest, ResolveDomainAnyOneAvailable) {
   LocalDomainResolverImpl resolver(
       "myhello.local", net::ADDRESS_FAMILY_UNSPECIFIED,
       base::Bind(&LocalDomainResolverTest::AddressCallback,
                  base::Unretained(this)), &mdns_client_);
 
-  EXPECT_CALL(*socket_factory_, OnSendTo(_))
-      .Times(4);  // Twice per query
+  EXPECT_CALL(socket_factory_, OnSendTo(_)).Times(4);  // Twice per query
 
   resolver.Start();
 
-  socket_factory_->SimulateReceive(
-      kSamplePacketAAAA, sizeof(kSamplePacketAAAA));
+  socket_factory_.SimulateReceive(kSamplePacketAAAA, sizeof(kSamplePacketAAAA));
 
   EXPECT_CALL(*this, AddressCallbackInternal(true, "", "a::1:2:3:4"));
 
   RunFor(base::TimeDelta::FromMilliseconds(150));
 }
 
 
 TEST_F(LocalDomainResolverTest, ResolveDomainAnyBothAvailable) {
   LocalDomainResolverImpl resolver(
       "myhello.local", net::ADDRESS_FAMILY_UNSPECIFIED,
       base::Bind(&LocalDomainResolverTest::AddressCallback,
                  base::Unretained(this)), &mdns_client_);
 
-  EXPECT_CALL(*socket_factory_, OnSendTo(_))
-      .Times(4);  // Twice per query
+  EXPECT_CALL(socket_factory_, OnSendTo(_)).Times(4);  // Twice per query
 
   resolver.Start();
 
   EXPECT_CALL(*this, AddressCallbackInternal(true, "1.2.3.4", "a::1:2:3:4"));
 
-  socket_factory_->SimulateReceive(
-      kSamplePacketAAAA, sizeof(kSamplePacketAAAA));
+  socket_factory_.SimulateReceive(kSamplePacketAAAA, sizeof(kSamplePacketAAAA));
 
-  socket_factory_->SimulateReceive(
-      kSamplePacketA, sizeof(kSamplePacketA));
+  socket_factory_.SimulateReceive(kSamplePacketA, sizeof(kSamplePacketA));
 }
 
 TEST_F(LocalDomainResolverTest, ResolveDomainNone) {
   LocalDomainResolverImpl resolver(
       "myhello.local", net::ADDRESS_FAMILY_UNSPECIFIED,
       base::Bind(&LocalDomainResolverTest::AddressCallback,
                  base::Unretained(this)), &mdns_client_);
 
-  EXPECT_CALL(*socket_factory_, OnSendTo(_))
-      .Times(4);  // Twice per query
+  EXPECT_CALL(socket_factory_, OnSendTo(_)).Times(4);  // Twice per query
 
   resolver.Start();
 
   EXPECT_CALL(*this, AddressCallbackInternal(false, "", ""));
 
   RunFor(base::TimeDelta::FromSeconds(4));
 }
 
 }  // namespace
 
 }  // namespace local_discovery