Issue 876913002: Remove CSSCanvas values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 876913002: Remove CSSCanvas values. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove CSSCanvas values. This was to support doing background: -webkit-canvas(#id) where you could then get the canvas with document.getCSSCanvasContext(id) and draw into it which is a poor form of custom drawing for elements. In Sky we'll have real custom painting instead of just background images hacked in like this. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9c391ee834d33907adcd7b042f08fe598c3b66e9

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -302 lines)			Patch
M	sky/engine/core/core.gni	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	sky/engine/core/css/CSSCanvasValue.h	View	1 chunk	+0 lines, -110 lines	0 comments	Download
D	sky/engine/core/css/CSSCanvasValue.cpp	View	1 chunk	+0 lines, -104 lines	0 comments	Download
M	sky/engine/core/css/CSSImageGeneratorValue.cpp	View	7 chunks	+0 lines, -14 lines	0 comments	Download
M	sky/engine/core/css/CSSValue.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	sky/engine/core/css/CSSValue.cpp	View	4 chunks	+0 lines, -8 lines	0 comments	Download
M	sky/engine/core/css/parser/BisonCSSParser-in.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/css/parser/CSSPropertyParser.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/css/parser/CSSPropertyParser.cpp	View	3 chunks	+0 lines, -20 lines	0 comments	Download
M	sky/engine/core/dom/Document.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	sky/engine/core/dom/Document.cpp	View	2 chunks	+0 lines, -27 lines	0 comments	Download
M	sky/engine/core/dom/Document.idl	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/html/HTMLCanvasElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/html/canvas/WebGLRenderingContext.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

esprehn

5 years, 11 months ago (2015-01-26 23:12:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9c391ee834d33907adcd7b042f08fe598c3b66e9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages