Issue 8769054: Redirect .S processing from pnacl-clang to pnacl-as

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8769054: Redirect .S processing from pnacl-clang to pnacl-as (Closed)

Created:
9 years ago by robertm

Modified:
9 years ago

Reviewers:
(google.com) Derek Schuff, pdox, krasin

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

Augmented pnacl-as to handle .S files, so we can remove .s/.S support from pnacl-clang. Also, make import statements style guide compliant BUG= http://code.google.com/p/nativeclient/issues/detail?id=1966 Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=7373

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -10 lines)			Patch
	M	pnacl/driver/pnacl-as.py	View	1	5 chunks	+36 lines, -10 lines	0 comments	Download

Total messages: 8 (0 generated)

pdox

woah woah, wait, what? Why are you backing in a call to Clang from pnacl-as? ...

9 years ago (2011-12-06 20:52:55 UTC) #3

pdox

pnacl-clang gives you access to the preprocessor. pnacl-clang -arch x86-32 -S foo.S -o foo.s

9 years ago (2011-12-06 20:56:39 UTC) #6

pdox

9 years ago (2011-12-06 20:59:40 UTC) #8

we need to have a meeting about this before you try to make any more "fixes".

I strongly believe this is the wrong direction.