Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 8769023: Add support for ignoring a string after the native keyword in a method, needed for compatability ... (Closed)

Created:
9 years ago by Brian Wilkerson
Modified:
9 years ago
Reviewers:
mmendez, Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add support for ignoring a string after the native keyword in a method, needed for compatability with frog Committed: https://code.google.com/p/dart/source/detail?r=2029

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 1 chunk +5 lines, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
Brian Wilkerson
We want to make dartc tolerant of the frog code so that the Seattle team ...
9 years ago (2011-12-01 23:18:48 UTC) #1
Brian Wilkerson
I was able to get the tests to pass this morning. PTAL.
9 years ago (2011-12-02 17:34:21 UTC) #2
mmendez
On 2011/12/02 17:34:21, Brian Wilkerson wrote: > I was able to get the tests to ...
9 years ago (2011-12-02 18:54:37 UTC) #3
Bill Hesse
I'm still getting an error on the runtime/bin files: http://codereview.chromium.org/8769023/diff/1/compiler/java/com/google/dart/compiler/parser/DartParser.java File compiler/java/com/google/dart/compiler/parser/DartParser.java (right): http://codereview.chromium.org/8769023/diff/1/compiler/java/com/google/dart/compiler/parser/DartParser.java#newcode1118 compiler/java/com/google/dart/compiler/parser/DartParser.java:1118: ...
9 years ago (2011-12-05 12:27:54 UTC) #4
Brian Wilkerson
9 years ago (2011-12-05 17:18:34 UTC) #5
> Why does this assume that native blocks are only on exported functions?

I don't know, but that's not the bug this CL was intended to fix. That's
pre-existing behavior that I didn't change. Perhaps you could add an issue for
dartc to track this problem.

Powered by Google App Engine
This is Rietveld 408576698