Issue 876853005: Add wheel support to sky-scrollable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 876853005: Add wheel support to sky-scrollable (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
ojan

CC:
ojan, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add wheel support to sky-scrollable This CL plumbs wheel events through Sky again and uses them in sky-scrollable. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ca88cacf590a4c7b04b16304faad926cbad47158

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+196 lines, -34 lines)			Patch
M	sky/engine/core/core.gni	View		4 chunks	+5 lines, -1 line	0 comments	Download
A	sky/engine/core/events/WheelEvent.h	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download
A	sky/engine/core/events/WheelEvent.cpp	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download
A	sky/engine/core/events/WheelEvent.idl	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	sky/engine/core/frame/NewEventHandler.h	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	sky/engine/core/frame/NewEventHandler.cpp	View		3 chunks	+14 lines, -0 lines	0 comments	Download
M	sky/engine/public/platform/WebInputEvent.h	View		4 chunks	+27 lines, -23 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	sky/examples/example-scrollable.sky	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/framework/sky-scrollable.sky	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	sky/viewer/converters/input_event_types.cc	View		3 chunks	+23 lines, -8 lines	0 comments	Download

Total messages: 5 (0 generated)

ojan

lgtm. Looks like you left out the new WheelEvent.* files though.

5 years, 11 months ago (2015-01-27 10:35:36 UTC) #3

abarth-chromium

On 2015/01/27 at 10:35:36, ojan wrote: > lgtm. Looks like you left out the new ...

5 years, 11 months ago (2015-01-27 17:32:33 UTC) #4

abarth-chromium

5 years, 11 months ago (2015-01-27 17:58:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ca88cacf590a4c7b04b16304faad926cbad47158 (presubmit successful).