wifi_sync: allow WifiCredentialSyncableServiceFactory to ignore LoginState

components/wifi_sync/wifi_credential_syncable_service_factory.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_WIFI_SYNC_WIFI_CREDENTIAL_SYNCABLE_SERVICE_FACTORY_H_
 #define COMPONENTS_WIFI_SYNC_WIFI_CREDENTIAL_SYNCABLE_SERVICE_FACTORY_H_
 
+#include <string>
+
 #include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/memory/singleton.h"
 #include "components/keyed_service/content/browser_context_keyed_service_factory.h"
 
 namespace content {
 class BrowserContext;
 }
 
 namespace wifi_sync {
 
+class WifiConfigDelegate;
 class WifiCredentialSyncableService;
 
 // Singleton that owns all WifiCredentialSyncableServices and
 // associates them with Profiles. Listens for the Profile's
 // destruction notification and cleans up the associated
 // WifiCredentialSyncableServices.
 class WifiCredentialSyncableServiceFactory
     : public BrowserContextKeyedServiceFactory {
  public:
   // Returns the SyncableService for |browser_context|, creating the
   // SyncableService if one does not already exist.
   static WifiCredentialSyncableService* GetForBrowserContext(
       content::BrowserContext* browser_context);
 
-  // Returns the singleton instance. As this class has no public
-  // instance methods, this function is not generally useful for
-  // external callers. This function is public only so that the
-  // Singleton template can reference it.
+  // Returns the singleton instance.
   static WifiCredentialSyncableServiceFactory* GetInstance();
 
+#if defined(OS_CHROMEOS)
+  void set_ignore_login_state_for_test(bool new_value) {

[mukesh agrawal, 2015/01/28 22:26:27]

- After renaming the member variable, the previous method was
CamelCaseVariable(). Changed to a mutator, to conform to style.

- I've omitted a comment for this method, since the comment would simply restate
the (one-line) implementation.

+    ignore_login_state_for_test_ = new_value;
+  }
+#endif
+
  private:
   friend struct DefaultSingletonTraits<WifiCredentialSyncableServiceFactory>;
 
   WifiCredentialSyncableServiceFactory();
   ~WifiCredentialSyncableServiceFactory() override;
 
   // BrowserContextKeyedServiceFactory implementation.
   KeyedService* BuildServiceInstanceFor(
       content::BrowserContext* context) const override;
 
+#if defined(OS_CHROMEOS)
+  // Returns a scoped pointer to a WifiConfigDelegate, which can be
+  // used to configure the ChromeOS Wi-Fi settings associated with
+  // |context|.
+  scoped_ptr<WifiConfigDelegate> BuildWifiConfigDelegateChromeOs(
+      content::BrowserContext* context) const;
+#endif
+
+#if defined(OS_CHROMEOS)

[mukesh agrawal, 2015/01/28 22:26:27]

While this #if block could be collapsed into the previous one, I thought it
would be better to maintain a separation between methods and variables.

+  // Whether or not we should use LoginState to associate a new
+  // SyncableService with a Shill profile. Should be set to true in
+  // sync integration tests, where it is not possible to control
+  // LoginState at the time SyncableServices are constructed.
+  bool ignore_login_state_for_test_ = false;

[mukesh agrawal, 2015/01/28 22:26:27]

Since this field is only present on ChromeOS, I'm using a non-static class
member initializer to set it. Alternatively, I can place an ifdef inside the
ctor body (setting this field outside the initializer list), or have the ctor be
platform-specific.

FWIW, non-static class member initializers are an approved C++11 feature, per
https://chromium-cpp.appspot.com/

+#endif
+
   DISALLOW_COPY_AND_ASSIGN(WifiCredentialSyncableServiceFactory);
 };
 
 }  // namespace wifi_sync
 
 #endif  // COMPONENTS_WIFI_SYNC_WIFI_CREDENTIAL_SYNCABLE_SERVICE_FACTORY_H_