Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Issue 876803005: Plugin Power Saver: --enable-plugin-power-saver only overrides ALLOW. (Closed)

Created:
5 years, 11 months ago by tommycli
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: --enable-plugin-power-saver only overrides ALLOW. --enable-plugin-power-saver flag previously overrode anything in the content settings flag. This breaks for BLOCK setting and unauthorized plugins, as the browser side needs to authorize the plugin first. This patch restricts the flag to only impact users on ALLOW. This makes sense to me, as the flag should not decrease the security of users who have explicitly chosen ASK or BLOCK. It will also dodge the bug. BUG=448171, 403800 Committed: https://crrev.com/f3c163fbbd0170983268e0c6dd9a63e93e17f0c9 Cr-Commit-Position: refs/heads/master@{#313210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tommycli
thestig: ptal, thanks!!
5 years, 11 months ago (2015-01-26 20:34:11 UTC) #2
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-27 00:51:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876803005/1
5 years, 11 months ago (2015-01-27 01:17:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 02:51:48 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 02:52:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3c163fbbd0170983268e0c6dd9a63e93e17f0c9
Cr-Commit-Position: refs/heads/master@{#313210}

Powered by Google App Engine
This is Rietveld 408576698