Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 876783003: Use data_deps rather then deps for mojo_bindings. (Closed)

Created:
5 years, 10 months ago by Slava Chigrin
Modified:
5 years, 10 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use data_deps rather then deps for mojo_bindings. Using deps caused pulling a bit of mojo code to chrome.exe. That caused weird unresolved externatls problems during Windows GN build. Committed: https://crrev.com/f7b4f01989be22df44d9b5475143ef98b653b1ac Cr-Commit-Position: refs/heads/master@{#313126}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M build/secondary/tools/grit/grit_rule.gni View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
Slava Chigrin
https://codereview.chromium.org/876783003/diff/1/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/876783003/diff/1/chrome/browser/BUILD.gn#newcode791 chrome/browser/BUILD.gn:791: data_deps = [ "//chrome/browser/ui/webui/omnibox:mojo_bindings" ] As far as I ...
5 years, 10 months ago (2015-01-26 19:40:26 UTC) #3
brettw
lgtm
5 years, 10 months ago (2015-01-26 19:44:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876783003/1
5 years, 10 months ago (2015-01-26 19:47:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-26 20:44:38 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f7b4f01989be22df44d9b5475143ef98b653b1ac Cr-Commit-Position: refs/heads/master@{#313126}
5 years, 10 months ago (2015-01-26 20:46:05 UTC) #8
dconnelly
5 years, 10 months ago (2015-01-28 12:59:32 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/880573005/ by dconnelly@chromium.org.

The reason for reverting is:
https://code.google.com/p/chromium/issues/detail?id=452847.

Powered by Google App Engine
This is Rietveld 408576698