Issue 876763002: Move city-list data into a separate module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 876763002: Move city-list data into a separate module (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
esprehn

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Move city-list data into a separate module This way other scrolling demos can share the data. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3a0fdc17ec05fc3afddef40341adcc7abcf44096

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5044 lines)			Patch
	M	sky/examples/city-list/city-data-service.sky	View		2 chunks	+1 line, -5003 lines	0 comments	Download
	A +	sky/examples/data/cities.sky	View		2 chunks	+1 line, -41 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

Committed patchset #1 (id:1) manually as 3a0fdc17ec05fc3afddef40341adcc7abcf44096 (presubmit successful).

5 years, 11 months ago (2015-01-26 17:41:30 UTC) #4

esprehn

wait did you forget to add a file? I see -5000 lines, but I don't ...

5 years, 11 months ago (2015-01-26 17:41:59 UTC) #5

esprehn

5 years, 11 months ago (2015-01-26 17:42:15 UTC) #6

Message was sent while issue was closed.

On 2015/01/26 at 17:41:59, esprehn wrote:
> wait did you forget to add a file? I see -5000 lines, but I don't see them
added back.

Oh clever git: 

copy from sky/examples/city-list/city-data-service.sky

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages