Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 876743002: check effective cache-size for fixed-budget caches (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

check effective cache-size for fixed-budget caches BUG=skia: Committed: https://skia.googlesource.com/skia/+/1d9e80f02b8260ffe2eb1944042cd79f10e38d43

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M src/core/SkBitmapProcState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkResourceCache.h View 2 chunks +5 lines, -0 lines 1 comment Download
M src/core/SkResourceCache.cpp View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
reed1
ptal
5 years, 11 months ago (2015-01-26 16:41:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876743002/1
5 years, 11 months ago (2015-01-26 16:41:49 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-26 16:41:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876743002/1
5 years, 11 months ago (2015-01-26 16:52:49 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-26 16:52:50 UTC) #9
robertphillips
lgtm https://codereview.chromium.org/876743002/diff/1/src/core/SkResourceCache.h File src/core/SkResourceCache.h (right): https://codereview.chromium.org/876743002/diff/1/src/core/SkResourceCache.h#newcode190 src/core/SkResourceCache.h:190: // returns the logical single allocation size (pinning ...
5 years, 11 months ago (2015-01-26 17:13:20 UTC) #10
robertphillips
lgtm lgtm
5 years, 11 months ago (2015-01-26 17:13:21 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 19:24:40 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1d9e80f02b8260ffe2eb1944042cd79f10e38d43

Powered by Google App Engine
This is Rietveld 408576698