Issue 22155. Send outline for both parsed and resolved Dart units.

pkg/analyzer/lib/src/generated/engine.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine;
 
 import "dart:math" as math;
@@ skipping 2353 matching lines @@
           } else {
             dartEntry.recordResolutionErrorInLibrary(
                 librarySource,
                 thrownException);
           }
           if (source != librarySource) {
             _workManager.add(source, SourcePriority.PRIORITY_PART);
           }
           ChangeNoticeImpl notice = _getNotice(source);
           notice.compilationUnit = unit;
-          notice.resolved = true;
           notice.setErrors(dartEntry.allErrors, lineInfo);
         }
       }
     }
     if (thrownException != null) {
       throw new AnalysisException('<rethrow>', thrownException);
     }
     return unitEntry;
   }
 
@@ skipping 64 matching lines @@
             dartEntry.recordResolutionErrorInLibrary(
                 librarySource,
                 thrownException);
             _cache.remove(source);
           }
           if (source != librarySource) {
             _workManager.add(source, SourcePriority.PRIORITY_PART);
           }
           ChangeNoticeImpl notice = _getNotice(source);
           notice.compilationUnit = unit;
-          notice.resolved = true;
           notice.setErrors(dartEntry.allErrors, lineInfo);
         }
       }
     }
     if (thrownException != null) {
       throw new AnalysisException('<rethrow>', thrownException);
     }
     return unitEntry;
   }
 
@@ skipping 2152 matching lines @@
    * @param task the task that was performed
    * @return an entry containing the computed results
    * @throws AnalysisException if the results could not be recorded
    */
   DartEntry
       _recordIncrementalAnalysisTaskResults(IncrementalAnalysisTask task) {
     CompilationUnit unit = task.compilationUnit;
     if (unit != null) {
       ChangeNoticeImpl notice = _getNotice(task.source);
       notice.compilationUnit = unit;
-      notice.resolved = true;
       _incrementalAnalysisCache =
           IncrementalAnalysisCache.cacheResult(task.cache, unit);
     }
     return null;
   }
 
   /**
    * Record the results produced by performing a [task] and return the cache
    * entry associated with the results.
    */
@@ skipping 41 matching lines @@
       }
     }
     dartEntry.setValue(DartEntry.PARSED_UNIT, task.compilationUnit);
     dartEntry.setValue(DartEntry.PARSE_ERRORS, task.errors);
     dartEntry.setValue(DartEntry.EXPORTED_LIBRARIES, task.exportedSources);
     dartEntry.setValue(DartEntry.IMPORTED_LIBRARIES, task.importedSources);
     dartEntry.setValue(DartEntry.INCLUDED_PARTS, newParts);
     _cache.storedAst(source);
     ChangeNoticeImpl notice = _getNotice(source);
     if (notice.compilationUnit == null) {
-      notice.compilationUnit = task.compilationUnit;
-      notice.resolved = false;
+      notice.parsedDartUnit = task.compilationUnit;
     }
     notice.setErrors(dartEntry.allErrors, task.lineInfo);
     // Verify that the incrementally parsed and resolved unit in the incremental
     // cache is structurally equivalent to the fully parsed unit
     _incrementalAnalysisCache = IncrementalAnalysisCache.verifyStructure(
         _incrementalAnalysisCache,
         source,
         task.compilationUnit);
     return dartEntry;
   }
@@ skipping 59 matching lines @@
       _cache.removedAst(source);
       throw new AnalysisException('<rethrow>', thrownException);
     }
     htmlEntry.setState(HtmlEntry.PARSED_UNIT, CacheState.FLUSHED);
     htmlEntry.setValue(HtmlEntry.RESOLVED_UNIT, task.resolvedUnit);
     htmlEntry.setValue(HtmlEntry.ELEMENT, task.element);
     htmlEntry.setValue(HtmlEntry.RESOLUTION_ERRORS, task.resolutionErrors);
     _cache.storedAst(source);
     ChangeNoticeImpl notice = _getNotice(source);
     notice.htmlUnit = task.resolvedUnit;
-    notice.resolved = true;
     LineInfo lineInfo = htmlEntry.getValue(SourceEntry.LINE_INFO);
     notice.setErrors(htmlEntry.allErrors, lineInfo);
     return htmlEntry;
   }
 
   /**
    * Record the results produced by performing a [task] and return the cache
    * entry associated with the results.
    */
   DartEntry _recordScanDartTaskResults(ScanDartTask task) {
@@ skipping 277 matching lines @@
           oldUnit.element.library.source;
       incrementalResolutionValidation_lastUnit = oldUnit;
       return false;
     }
     // prepare notices
     units.forEach((Source source, CompilationUnit unit) {
       DartEntry dartEntry = _cache.get(source);
       LineInfo lineInfo = getLineInfo(source);
       ChangeNoticeImpl notice = _getNotice(source);
       notice.compilationUnit = unit;
-      notice.resolved = true;
       notice.setErrors(dartEntry.allErrors, lineInfo);
     });
     // OK
     return true;
   }
 
   /**
    * Check the cache for any invalid entries (entries whose modification time does not match the
    * modification time of the source associated with the entry). Invalid entries will be marked as
    * invalid so that the source will be re-analyzed.
@@ skipping 2155 matching lines @@
 
   const CacheState(String name, int ordinal) : super(name, ordinal);
 }
 
 /**
  * An object that represents a change to the analysis results associated with a
  * given source.
  */
 abstract class ChangeNotice implements AnalysisErrorInfo {
   /**
-   * Return the AST that changed as a result of the analysis, or `null` if the
-   * AST was not changed. Use the getter [resolved] to determine whether the
-   * AST has been fully resolved.
+   * The parsed, but maybe not resolved Dart AST that changed as a result of
+   * the analysis, or `null` if the AST was not changed.
+   */
+  CompilationUnit get parsedDartUnit;
+
+  /**
+   * The fully resolved Dart AST that changed as a result of the analysis, or
+   * `null` if the AST was not changed.
    */
   CompilationUnit get compilationUnit;

[Brian Wilkerson, 2015/01/26 19:11:03]

Should we change the name to "resolvedDartUnit" for consistency?

 
   /**
-   * Return the HTML that changed as a result of the analysis, or `null` if the
-   * HTML was not changed. Use the getter [resolved] to determine whether the
-   * HTML has been fully resolved.
+   * The fully resolved HTML AST that changed as a result of the analysis, or
+   * `null` if the AST was not changed.
    */
   ht.HtmlUnit get htmlUnit;

[Brian Wilkerson, 2015/01/26 19:11:03]

"resolvedHtmlUnit"?

 
   /**
-   * Return `true` if the [compilationUnit] or [htmlUnit] (whichever is
-   * currently set) has been resolved.
-   */
-  bool get resolved;
-
-  /**
    * Return the source for which the result is being reported.
    */
   Source get source;
 }
 
 /**
  * An implementation of a [ChangeNotice].
  */
 class ChangeNoticeImpl implements ChangeNotice {
   /**
    * An empty list of change notices.
    */
   static const List<ChangeNoticeImpl> EMPTY_ARRAY = const <ChangeNoticeImpl>[];
 
   /**
    * The source for which the result is being reported.
    */
   final Source source;
 
   /**
-   * The AST that changed as a result of the analysis, or `null` if the AST was
-   * not changed. Use the getter [resolved] to determine whether the AST has
-   * been fully resolved.
+   * The parsed, but maybe not resolved Dart AST that changed as a result of
+   * the analysis, or `null` if the AST was not changed.
+   */
+  CompilationUnit parsedDartUnit;
+
+  /**
+   * The fully resolved Dart AST that changed as a result of the analysis, or
+   * `null` if the AST was not changed.
    */
   CompilationUnit compilationUnit;
 
   /**
-   * The HTML that changed as a result of the analysis, or `null` if the HTML
-   * was not changed. Use the getter [resolved] to determine whether the HTML
-   * has been fully resolved.
+   * The fully resolved HTML AST that changed as a result of the analysis, or
+   * `null` if the AST was not changed.
    */
   ht.HtmlUnit htmlUnit;
 
   /**
-   * A flag indicating whether the [compilationUnit] or [htmlUnit] (whichever is
-   * currently set) has been resolved.
-   */
-  bool resolved = false;
-
-  /**
    * The errors that changed as a result of the analysis, or `null` if errors
    * were not changed.
    */
   List<AnalysisError> _errors;
 
   /**
    * The line information associated with the source, or `null` if errors were
    * not changed.
    */
   LineInfo _lineInfo;
@@ skipping 4969 matching lines @@
     if (element.id == _id) {
       result = element;
       throw new _ElementByIdFinderException();
     }
     super.visitElement(element);
   }
 }
 
 class _ElementByIdFinderException {
 }