Issue 876663003: Remove layoutBlock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 876663003: Remove layoutBlock. (Closed)

Created:
5 years, 11 months ago by ojan

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium, esprehn, eseidel

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove layoutBlock. We've simplified RenderBlock::layout to the point where we no longer need it or layoutBlock. The RenderBlock subclasses can just override layout the way every other renderer does. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/37058391e9b6dc8e4ae9e7dd78dc3fe97d33ce96

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -29 lines)			Patch
M	sky/engine/core/rendering/RenderBlock.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlock.cpp	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlockFlow.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlockFlow.cpp	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	sky/engine/core/rendering/RenderFlexibleBox.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/rendering/RenderFlexibleBox.cpp	View	1 chunk	+3 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

ojan

5 years, 11 months ago (2015-01-27 05:33:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
37058391e9b6dc8e4ae9e7dd78dc3fe97d33ce96 (presubmit successful).