win: make browser_tests work locally (yes, really)

win: make browser_tests work locally (yes, really)

Apparently nobody has tried to run them locally in months.

BUG=452130
TBR=eroman@chromium.org

Committed: https://crrev.com/39cd21120a27c8d3676a84e10637176c8cc69540
Cr-Commit-Position: refs/heads/master@{#313976}

[Nico, 2015-01-27 17:22:15]

thakis@chromium.org changed reviewers:
+ eroman@chromium.org, scottmg@chromium.org

[scottmg, 2015-01-27 17:29:34]

lgtm

[Nico, 2015-01-27 17:39:34]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-27 17:40:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876633004/20001

[scottmg, 2015-01-27 17:43:07]

[ I never run them locally w/o --gtest_filter=Something.Failing 'cuz they take
toooooooooooooo long these days. :( ]

[commit-bot: I haz the power, 2015-01-27 17:47:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 17:47:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2015-01-27 17:57:49]

TBR'ing eroman

Even with --gtest_filter they're broken, if your filtered test happens to start
up a test server. But yeah, I think browser_tests don't all pass locally on OS X
either :-/

[Nico, 2015-01-27 17:57:52]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-27 17:59:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876633004/20001

[commit-bot: I haz the power, 2015-01-27 17:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 17:59:32]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2015-01-27 18:44:38]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-27 18:45:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876633004/20001

[eroman, 2015-01-27 19:08:50]

lgtm

[commit-bot: I haz the power, 2015-01-27 19:44:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 19:44:04]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Nico, 2015-01-27 19:45:08]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-27 19:46:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876633004/20001

[commit-bot: I haz the power, 2015-01-27 20:34:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 20:34:10]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Nico, 2015-01-27 20:37:15]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-27 20:38:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876633004/20001

[commit-bot: I haz the power, 2015-01-27 21:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 21:14:03]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Nico, 2015-01-29 18:16:02]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-29 18:16:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876633004/20001

[commit-bot: I haz the power, 2015-01-29 19:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-29 19:51:28]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Nico, 2015-01-30 18:41:44]

scottmg, eroman: Ok, please take another look at patch set 3. This now calls cmd
/c python -c 'import sys; print sys.executable' to find the python executable,
and then returns the path of that.

I couldn't find a way to force cmd into a certain codepage though, so this
assumes that cmd's output is ascii (which in general isn't true).

[eroman, 2015-01-30 19:01:48]

LGTM.

Looks like the same technique is used for GN and GYP

[scottmg, 2015-01-30 19:46:00]

lgtm, thanks for persevering.

https://codereview.chromium.org/876633004/diff/40001/net/test/python_utils.cc
File net/test/python_utils.cc (right):

https://codereview.chromium.org/876633004/diff/40001/net/test/python_utils.cc...
net/test/python_utils.cc:123: // This does only work if cmd.exe doesn't use a
non-US codepage.
It think it'd only fail if depot_tools src is in a non-ASCII path, which
realistically is not likely to work with many of our tools.

[Nico, 2015-01-30 19:50:03]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-30 19:50:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876633004/40001

[commit-bot: I haz the power, 2015-01-30 20:19:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-30 20:20:38]

Patchset 3 (id:??) landed as
https://crrev.com/39cd21120a27c8d3676a84e10637176c8cc69540
Cr-Commit-Position: refs/heads/master@{#313976}