Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 876633003: Chromecast: make GYP targets more common between Android/Chromecast.Makes cast_crash_client common a (Closed)

Created:
5 years, 11 months ago by gunsch
Modified:
5 years, 10 months ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: Makes cast_crash_client common across builds. R=lcwu@chromium.org,byungchul@chromium.org BUG=internal b/18934906 Committed: https://crrev.com/7b28897b0d5ddb916cdaf0ccab227c27520a068b Cr-Commit-Position: refs/heads/master@{#314413}

Patch Set 1 #

Patch Set 2 : reduce scope to just cast_crash_client #

Patch Set 3 : updates commit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M chromecast/chromecast.gyp View 1 4 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
5 years, 11 months ago (2015-01-26 16:44:37 UTC) #1
gunsch
ping?
5 years, 10 months ago (2015-02-02 19:22:46 UTC) #2
lcwu1
lgtm
5 years, 10 months ago (2015-02-02 19:31:39 UTC) #3
byungchul
lgtm
5 years, 10 months ago (2015-02-02 22:27:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876633003/40001
5 years, 10 months ago (2015-02-03 21:20:44 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-03 21:59:40 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 22:02:03 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7b28897b0d5ddb916cdaf0ccab227c27520a068b
Cr-Commit-Position: refs/heads/master@{#314413}

Powered by Google App Engine
This is Rietveld 408576698