Adds a CancellableTaskFactory and exposes postLoadingTasks to Blink

Adds a CancellableTaskFactory and exposes postLoadingTasks to Blink

This patch is needed to let us post HTML parsing tasks on the renderer
scheduler's loading task queue.  The CancellableTaskFactory is
inspired by base::CancelableCallback and is intended to replace
the the startOneShot(0) timers without the overhead of the blink
timer heap.

BUG=391005
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189509

[alex clarke (OOO till 29th), 2015-01-26 11:37:40]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[alex clarke (OOO till 29th), 2015-01-26 11:38:26]

alexclarke@chromium.org changed reviewers:
+ jochen@chromium.org

[alex clarke (OOO till 29th), 2015-01-26 11:38:26]

jochen@chromium.org: Please review changes in

[jochen (gone - plz use gerrit), 2015-01-26 15:53:32]

what do you need the cancellable tasks for? They're not referenced anywhere in
this cl.

can you add them when you actually need them?

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
File Source/platform/scheduler/CancellableTaskFactory.h (right):

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
Source/platform/scheduler/CancellableTaskFactory.h:38: public:
nit. also make this non copyable

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
File Source/platform/scheduler/Scheduler.cpp (right):

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
Source/platform/scheduler/Scheduler.cpp:36: public:
non-copyable

https://codereview.chromium.org/876623002/diff/1/public/platform/WebScheduler.h
File public/platform/WebScheduler.h (right):

https://codereview.chromium.org/876623002/diff/1/public/platform/WebScheduler...
public/platform/WebScheduler.h:46: // Takes ownership of |IdleTask|. Can be
called from any thread.
nit. WebThread::Task instead of IdleTask

[Sami, 2015-01-26 16:08:14]

skyostil@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Sami, 2015-01-26 16:08:15]

+rmcilroy since he wanted to have a peek too.

I think the cancellable task factory looks great.

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
File Source/platform/scheduler/CancellableTaskFactory.cpp (right):

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
Source/platform/scheduler/CancellableTaskFactory.cpp:21:
m_weakPtrFactory.revokeAll();
Perhaps just call cancel() here instead of duplicating the code?

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
Source/platform/scheduler/CancellableTaskFactory.cpp:28:
m_weakPtr->runInternal();
nit: I think you could call m_closure here directly to save having another
function (assuming the revokeAll call isn't needed)?

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
Source/platform/scheduler/CancellableTaskFactory.cpp:33:
m_weakPtrFactory.revokeAll();
Do we need to do this? Task::run is guaranteed to be called at most once.

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
File Source/platform/scheduler/CancellableTaskFactory.h (right):

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
Source/platform/scheduler/CancellableTaskFactory.h:39: explicit
CancellableTask(WeakPtr<CancellableTaskFactory> weakPtr) : m_weakPtr(weakPtr) {
}
nit: Something like |factory| would be a little more descriptive than |weakPtr|.

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
File Source/platform/scheduler/Scheduler.h (right):

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
Source/platform/scheduler/Scheduler.h:14: class CancellableTask;
Unused?

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
Source/platform/scheduler/Scheduler.h:36: void postLoadingTask(const
TraceLocation&, PassOwnPtr<Closure>);
Should we have a variant of this that takes a Task? Otherwise
CancellableTaskClosure isn't really compatible with this.

[alex clarke (OOO till 29th), 2015-01-26 17:00:46]

I've bundled in the HTML Parser changes as requested.  PTAL

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
File Source/platform/scheduler/CancellableTaskFactory.cpp (right):

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
Source/platform/scheduler/CancellableTaskFactory.cpp:21:
m_weakPtrFactory.revokeAll();
On 2015/01/26 16:08:14, Sami wrote:
> Perhaps just call cancel() here instead of duplicating the code?

Done.

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
Source/platform/scheduler/CancellableTaskFactory.cpp:28:
m_weakPtr->runInternal();
On 2015/01/26 16:08:14, Sami wrote:
> nit: I think you could call m_closure here directly to save having another
> function (assuming the revokeAll call isn't needed)?

Done.

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
Source/platform/scheduler/CancellableTaskFactory.cpp:33:
m_weakPtrFactory.revokeAll();
On 2015/01/26 16:08:14, Sami wrote:
> Do we need to do this? Task::run is guaranteed to be called at most once.

Yes we do because there's code in the HTML parser scheduler that relies on
isPending() returning false in side a function called from the callback. 
Reminds me I need to add a test for that.

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
File Source/platform/scheduler/CancellableTaskFactory.h (right):

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Ca...
Source/platform/scheduler/CancellableTaskFactory.h:38: public:
On 2015/01/26 15:53:31, jochen (slow) wrote:
> nit. also make this non copyable

Done.

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
File Source/platform/scheduler/Scheduler.cpp (right):

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
Source/platform/scheduler/Scheduler.cpp:36: public:
On 2015/01/26 15:53:31, jochen (slow) wrote:
> non-copyable

Done.

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
File Source/platform/scheduler/Scheduler.h (right):

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
Source/platform/scheduler/Scheduler.h:14: class CancellableTask;
On 2015/01/26 16:08:15, Sami wrote:
> Unused?

Done.

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
Source/platform/scheduler/Scheduler.h:36: void postLoadingTask(const
TraceLocation&, PassOwnPtr<Closure>);
On 2015/01/26 16:08:15, Sami wrote:
> Should we have a variant of this that takes a Task? Otherwise
> CancellableTaskClosure isn't really compatible with this.

I think WebScheduler::postLoadingTask() takes care of that?

https://codereview.chromium.org/876623002/diff/1/public/platform/WebScheduler.h
File public/platform/WebScheduler.h (right):

https://codereview.chromium.org/876623002/diff/1/public/platform/WebScheduler...
public/platform/WebScheduler.h:46: // Takes ownership of |IdleTask|. Can be
called from any thread.
On 2015/01/26 15:53:31, jochen (slow) wrote:
> nit. WebThread::Task instead of IdleTask

Done.

[Sami, 2015-01-26 17:18:35]

https://codereview.chromium.org/876623002/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLParserScheduler.cpp (right):

https://codereview.chromium.org/876623002/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLParserScheduler.cpp:116:
Platform::current()->scheduler()->postLoadingTask(WebTraceLocation(FROM_HERE),
m_cancelableContinueParse.task());
I think it's a little unfortunate that we need to reach into the platform here.
IMO WebScheduler should be the convenient interface for all clients to use and
the one in platform is just an implementation detail. Maybe the cancellable
factory should return a closure instead?

https://codereview.chromium.org/876623002/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLParserScheduler.h (right):

https://codereview.chromium.org/876623002/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLParserScheduler.h:103: CancellableTaskFactory
m_cancelableContinueParse;
s/cancelable/cancellable/ (or the other way around as long as its consistent)

https://codereview.chromium.org/876623002/diff/20001/Source/platform/schedule...
File Source/platform/scheduler/Scheduler.cpp (right):

https://codereview.chromium.org/876623002/diff/20001/Source/platform/schedule...
Source/platform/scheduler/Scheduler.cpp:43: virtual ~ClosureRunner()
s/virtual/override/

[alex clarke (OOO till 29th), 2015-01-26 17:31:36]

https://codereview.chromium.org/876623002/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLParserScheduler.cpp (right):

https://codereview.chromium.org/876623002/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLParserScheduler.cpp:116:
Platform::current()->scheduler()->postLoadingTask(WebTraceLocation(FROM_HERE),
m_cancelableContinueParse.task());
On 2015/01/26 17:18:34, Sami wrote:
> I think it's a little unfortunate that we need to reach into the platform
here.
> IMO WebScheduler should be the convenient interface for all clients to use and
> the one in platform is just an implementation detail. Maybe the cancellable
> factory should return a closure instead?

If we do that we'll have the following nested things:
* WTF::Bind closure posted to CancellableTaskFactory
* A WTF::Bind to call a new run method (the one we just deleted) on
CancellableTaskFactory
* An instance of ClosureRunner
* The chromium closure posted on the run loop.


If we keep it like this we'll have a slightly better situation with:
* WTF::Bind closure posted to CancellableTaskFactory
* The CancellableTask
* The chromium closure posted on the run loop.

https://codereview.chromium.org/876623002/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLParserScheduler.h (right):

https://codereview.chromium.org/876623002/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLParserScheduler.h:103: CancellableTaskFactory
m_cancelableContinueParse;
On 2015/01/26 17:18:34, Sami wrote:
> s/cancelable/cancellable/ (or the other way around as long as its consistent)

Done.

https://codereview.chromium.org/876623002/diff/20001/Source/platform/schedule...
File Source/platform/scheduler/Scheduler.cpp (right):

https://codereview.chromium.org/876623002/diff/20001/Source/platform/schedule...
Source/platform/scheduler/Scheduler.cpp:43: virtual ~ClosureRunner()
On 2015/01/26 17:18:34, Sami wrote:
> s/virtual/override/

Done.

[alex clarke (OOO till 29th), 2015-01-26 18:00:33]

As discussed offline with Sami, the Scheduler::postLoadingTask now accepts tasks
as well as closures.

[Sami, 2015-01-26 18:07:41]

Great, I think interface-wise this looks perfect. One question about the parser
though.

https://codereview.chromium.org/876623002/diff/60001/Source/core/html/parser/...
File Source/core/html/parser/HTMLDocumentParser.cpp (right):

https://codereview.chromium.org/876623002/diff/60001/Source/core/html/parser/...
Source/core/html/parser/HTMLDocumentParser.cpp:534: if
(m_parserScheduler->yieldIfNeeded(session,
m_speculations.first()->startingScript))
I wonder if we should move this yield point in a separate patch? I foresee much
flake in our future :)

[rmcilroy, 2015-01-26 18:09:02]

I'm liking this a lot more than the previous patch-set - thanks for iterating! 
I agree with all Sami's and Jochen's comments and have a couple more.

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
File Source/platform/scheduler/Scheduler.cpp (right):

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
Source/platform/scheduler/Scheduler.cpp:35: class ClosureRunner : public
WebThread::Task {
nit - ClosureRunnerTask (if you take my suggestion to expose this class as a top
level class).

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
File Source/platform/scheduler/Scheduler.h (right):

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
Source/platform/scheduler/Scheduler.h:36: void postLoadingTask(const
TraceLocation&, PassOwnPtr<Closure>);
On 2015/01/26 16:08:15, Sami wrote:
> Should we have a variant of this that takes a Task? Otherwise
> CancellableTaskClosure isn't really compatible with this.

Would it be worth only having the WebThread::Task API and exposing ClosureRunner
at the same level as CancelableTaskFactory to enable clients to build Tasks
easily?  This would keep the API consistent.

[jochen (gone - plz use gerrit), 2015-01-27 09:59:20]

lgtm

https://codereview.chromium.org/876623002/diff/60001/Source/platform/schedule...
File Source/platform/scheduler/CancellableTaskFactory.h (right):

https://codereview.chromium.org/876623002/diff/60001/Source/platform/schedule...
Source/platform/scheduler/CancellableTaskFactory.h:52: friend class
CancellableTask;
inner classes are automatically friends, no?

[alex clarke (OOO till 29th), 2015-01-27 11:41:19]

I exposed ClosureRunnerTask as Ross suggested. PTAL.

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
File Source/platform/scheduler/Scheduler.cpp (right):

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
Source/platform/scheduler/Scheduler.cpp:35: class ClosureRunner : public
WebThread::Task {
On 2015/01/26 18:09:01, rmcilroy wrote:
> nit - ClosureRunnerTask (if you take my suggestion to expose this class as a
top
> level class).

Done.

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
File Source/platform/scheduler/Scheduler.h (right):

https://codereview.chromium.org/876623002/diff/1/Source/platform/scheduler/Sc...
Source/platform/scheduler/Scheduler.h:36: void postLoadingTask(const
TraceLocation&, PassOwnPtr<Closure>);
On 2015/01/26 18:09:01, rmcilroy wrote:
> On 2015/01/26 16:08:15, Sami wrote:
> > Should we have a variant of this that takes a Task? Otherwise
> > CancellableTaskClosure isn't really compatible with this.
> 
> Would it be worth only having the WebThread::Task API and exposing
ClosureRunner
> at the same level as CancelableTaskFactory to enable clients to build Tasks
> easily?  This would keep the API consistent.

Done.

https://codereview.chromium.org/876623002/diff/60001/Source/core/html/parser/...
File Source/core/html/parser/HTMLDocumentParser.cpp (right):

https://codereview.chromium.org/876623002/diff/60001/Source/core/html/parser/...
Source/core/html/parser/HTMLDocumentParser.cpp:534: if
(m_parserScheduler->yieldIfNeeded(session,
m_speculations.first()->startingScript))
On 2015/01/26 18:07:41, Sami wrote:
> I wonder if we should move this yield point in a separate patch? I foresee
much
> flake in our future :)

Done.

https://codereview.chromium.org/876623002/diff/60001/Source/platform/schedule...
File Source/platform/scheduler/CancellableTaskFactory.h (right):

https://codereview.chromium.org/876623002/diff/60001/Source/platform/schedule...
Source/platform/scheduler/CancellableTaskFactory.h:52: friend class
CancellableTask;
On 2015/01/27 09:59:20, jochen (slow) wrote:
> inner classes are automatically friends, no?

Done.

[rmcilroy, 2015-01-27 11:53:29]

Nice, looks really good to me, thanks Alex!

lgtm.

[Sami, 2015-01-27 11:54:29]

Thanks, lgtm. I think we'll eventually want to make
CancellableTaskFactory::task() return an OwnPtr, but let's do that later and fix
the same thing in WebThread too.

https://codereview.chromium.org/876623002/diff/80001/Source/platform/schedule...
File Source/platform/scheduler/CancellableTaskFactoryTest.cpp (right):

https://codereview.chromium.org/876623002/diff/80001/Source/platform/schedule...
Source/platform/scheduler/CancellableTaskFactoryTest.cpp:73: factory.cancel();
Did you mean to run the task here instead?

[alex clarke (OOO till 29th), 2015-01-27 13:02:15]

Thanks

https://codereview.chromium.org/876623002/diff/80001/Source/platform/schedule...
File Source/platform/scheduler/CancellableTaskFactoryTest.cpp (right):

https://codereview.chromium.org/876623002/diff/80001/Source/platform/schedule...
Source/platform/scheduler/CancellableTaskFactoryTest.cpp:73: factory.cancel();
On 2015/01/27 11:54:28, Sami wrote:
> Did you mean to run the task here instead?

Done.

[alex clarke (OOO till 29th), 2015-01-27 13:02:23]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-01-27 13:02:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876623002/100001

[commit-bot: I haz the power, 2015-01-27 13:08:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 13:08:17]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/40122)

[alex clarke (OOO till 29th), 2015-01-27 14:08:26]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-01-27 14:09:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876623002/120001

[kouhei (in TOK), 2015-01-27 14:09:11]

parser changes lgtm. Thanks!

[commit-bot: I haz the power, 2015-01-27 14:15:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 14:15:20]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)

[alex clarke (OOO till 29th), 2015-01-27 14:21:25]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-01-27 14:22:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876623002/140001

[commit-bot: I haz the power, 2015-01-27 14:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 14:40:39]

Try jobs failed on following builders:
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[alex clarke (OOO till 29th), 2015-01-27 14:47:36]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-01-27 14:48:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876623002/160001

[commit-bot: I haz the power, 2015-01-27 14:54:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 14:54:59]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/4...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)

[alex clarke (OOO till 29th), 2015-01-27 15:04:07]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-01-27 15:05:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876623002/180001

[commit-bot: I haz the power, 2015-01-27 15:23:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 15:23:20]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/4...)

[alex clarke (OOO till 29th), 2015-01-27 15:48:29]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-01-27 15:49:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876623002/200001

[commit-bot: I haz the power, 2015-01-27 16:03:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 16:03:39]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/4...)

[alex clarke (OOO till 29th), 2015-01-27 16:10:38]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-01-27 16:11:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876623002/220001

[commit-bot: I haz the power, 2015-01-27 16:28:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 16:28:31]

Try jobs failed on following builders:
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[alex clarke (OOO till 29th), 2015-01-27 16:31:36]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-01-27 16:32:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876623002/240001

[commit-bot: I haz the power, 2015-01-27 19:23:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 19:23:08]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/4...)

[alex clarke (OOO till 29th), 2015-01-30 22:43:52]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-01-30 22:44:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876623002/240001

[commit-bot: I haz the power, 2015-01-30 22:48:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-30 22:48:40]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/40674)

[alex clarke (OOO till 29th), 2015-02-02 10:29:40]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-02-02 10:30:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876623002/260001

[alex clarke (OOO till 29th), 2015-02-02 11:04:55]

The CQ bit was unchecked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2015-02-03 11:08:45]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-02-03 11:09:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876623002/260001

[commit-bot: I haz the power, 2015-02-03 13:50:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 13:50:16]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/4...)

[alex clarke (OOO till 29th), 2015-02-04 14:26:52]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2015-02-04 14:27:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876623002/260001

[commit-bot: I haz the power, 2015-02-04 16:01:08]

Committed patchset #14 (id:260001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189509