Only use FreeSpace objects in the free list.

Only use FreeSpace objects in the free list.

This solves an issue with the custom startup snapshot, in cases where
deserializing the isolate requires more than one page per space.

R=hpayer@chromium.org

Committed: https://crrev.com/66964395108f03220cb6f45ddc73c5965e2c76a9
Cr-Commit-Position: refs/heads/master@{#26285}

[Hannes Payer (out of office), 2015-01-27 08:05:49]

LGTM, just nits. Thanks for simplifying this.

https://codereview.chromium.org/876613002/diff/20001/src/allocation-tracker.cc
File src/allocation-tracker.cc (right):

https://codereview.chromium.org/876613002/diff/20001/src/allocation-tracker.c...
src/allocation-tracker.cc:225: bool IsFillerOrFreeListNode(HeapObject* object) {
Rename to IsFillerOrFreeSpace

https://codereview.chromium.org/876613002/diff/20001/src/allocation-tracker.c...
src/allocation-tracker.cc:243:
DCHECK(IsFillerOrFreeListNode(HeapObject::FromAddress(addr)));
I don't think the two DCHECKs above are useful. We can trust our
CreateFillerObjectAt method. You can remove them.

https://codereview.chromium.org/876613002/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/876613002/diff/20001/src/objects.h#newcode4451
src/objects.h:4451: // FreeSpace are free blocks in the heap.  They look like
heap objects
... are fixed size memory blocks...

https://codereview.chromium.org/876613002/diff/20001/src/objects.h#newcode4454
src/objects.h:4454: // of the next FreeSpace object (or NULL) in the free list.
Used by the heap and GC.

[Yang, 2015-01-27 08:49:40]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-01-27 08:49:49]

https://codereview.chromium.org/876613002/diff/20001/src/allocation-tracker.cc
File src/allocation-tracker.cc (right):

https://codereview.chromium.org/876613002/diff/20001/src/allocation-tracker.c...
src/allocation-tracker.cc:225: bool IsFillerOrFreeListNode(HeapObject* object) {
On 2015/01/27 08:05:49, Hannes Payer wrote:
> Rename to IsFillerOrFreeSpace

Acknowledged.

https://codereview.chromium.org/876613002/diff/20001/src/allocation-tracker.c...
src/allocation-tracker.cc:243:
DCHECK(IsFillerOrFreeListNode(HeapObject::FromAddress(addr)));
On 2015/01/27 08:05:49, Hannes Payer wrote:
> I don't think the two DCHECKs above are useful. We can trust our
> CreateFillerObjectAt method. You can remove them.

Done.

https://codereview.chromium.org/876613002/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/876613002/diff/20001/src/objects.h#newcode4451
src/objects.h:4451: // FreeSpace are free blocks in the heap.  They look like
heap objects
On 2015/01/27 08:05:49, Hannes Payer wrote:
> ... are fixed size memory blocks...

Done.

https://codereview.chromium.org/876613002/diff/20001/src/objects.h#newcode4454
src/objects.h:4454: // of the next FreeSpace object (or NULL) in the free list.
On 2015/01/27 08:05:49, Hannes Payer wrote:
> Used by the heap and GC.

Done.

[commit-bot: I haz the power, 2015-01-27 08:50:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876613002/40001

[commit-bot: I haz the power, 2015-01-27 09:20:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-27 09:20:39]

Patchset 3 (id:??) landed as
https://crrev.com/66964395108f03220cb6f45ddc73c5965e2c76a9
Cr-Commit-Position: refs/heads/master@{#26285}

[Yang, 2015-01-27 09:40:34]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/882443004/ by yangguo@chromium.org.

The reason for reverting is: Test failures.