Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 876583002: Add a use counter for async XHR. (Closed)

Created:
5 years, 11 months ago by yhirano
Modified:
5 years, 11 months ago
CC:
blink-reviews, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a use counter for async XHR. Add a use counter for asynchronous XMLHttpRequest.send call. BUG=436770 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189008

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
yhirano
5 years, 11 months ago (2015-01-26 03:18:13 UTC) #2
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/876583002/diff/1/Source/core/xmlhttprequest/XMLHttpRequest.cpp File Source/core/xmlhttprequest/XMLHttpRequest.cpp (right): https://codereview.chromium.org/876583002/diff/1/Source/core/xmlhttprequest/XMLHttpRequest.cpp#newcode1003 Source/core/xmlhttprequest/XMLHttpRequest.cpp:1003: UseCounter::count(&executionContext, UseCounter::XMLHttpRequestAsynchronous); This counts sendForInspectorXHRReplay(), too. It's for ...
5 years, 11 months ago (2015-01-27 05:07:42 UTC) #3
yhirano
+kouhei for OWNER review.
5 years, 11 months ago (2015-01-27 05:57:20 UTC) #5
kouhei (in TOK)
lgtm
5 years, 11 months ago (2015-01-27 06:51:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876583002/1
5 years, 11 months ago (2015-01-27 06:52:06 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 08:05:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189008

Powered by Google App Engine
This is Rietveld 408576698