Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 8765: * Use new RegExp parser. (Closed)

Created:
12 years, 1 month ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use new RegExp parser for syntax checking patterns and selecting atom matching. Delay compilation of JSCRE regexps until their first use. Includes previous change-list, which got committed to the wrong branch.

Patch Set 1 #

Patch Set 2 : Use new RegExp parser. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -16 lines) Patch
M regexp2000/src/ast.h View 11 chunks +13 lines, -0 lines 0 comments Download
M regexp2000/src/ast.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M regexp2000/src/jsregexp.h View 4 chunks +13 lines, -3 lines 0 comments Download
M regexp2000/src/jsregexp.cc View 1 7 chunks +55 lines, -12 lines 0 comments Download
M regexp2000/src/objects.h View 2 chunks +6 lines, -0 lines 0 comments Download
M regexp2000/src/objects-debug.cc View 1 chunk +2 lines, -1 line 0 comments Download
M regexp2000/src/objects-inl.h View 1 chunk +16 lines, -0 lines 0 comments Download
M regexp2000/src/parser.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Incremental code review. This CL also contains all the changes of CL 8760, which got ...
12 years, 1 month ago (2008-10-31 12:50:36 UTC) #1
Christian Plesner Hansen
12 years, 1 month ago (2008-10-31 13:39:33 UTC) #2
Lgtm.

http://codereview.chromium.org/8765/diff/1/4
File regexp2000/src/jsregexp.cc (right):

http://codereview.chromium.org/8765/diff/1/4#newcode340
Line 340: ASSERT(re->TypeTag() == JSRegExp::JSCRE);
Use ASSERT_EQ(a, b) instead of ASSERT(a == b) since it displays the values when
it fails.

http://codereview.chromium.org/8765/diff/1/4#newcode509
Line 509: ASSERT(regexp->TypeTag() == JSRegExp::JSCRE);
Ditto

http://codereview.chromium.org/8765/diff/1/4#newcode536
Line 536: ASSERT(regexp->TypeTag() == JSRegExp::JSCRE);
Ditto

Powered by Google App Engine
This is Rietveld 408576698