NaCl: Move src/trusted/plugin/ to components/nacl/renderer/plugin/

NaCl: Move src/trusted/plugin/ to components/nacl/renderer/plugin/

This moves the "trusted plugin" code so that all the NaCl
renderer-side code is in the same place, under
components/nacl/renderer/.  I've used the "renderer/plugin/" subdir so
that this legacy code is distinguished from the newer code that's
directly under "renderer/".

This will make further incremental cleanups easier: It will enable
closer integration between renderer/* and renderer/plugin/*.  Rather
than indirecting through PPB_NaCl_Private/PPP_PexeStreamHandler, it
would be reasonable for the two sides to share pointers to C++
objects.  Doing that will be more acceptable when the two sides live
in the same directory.

 * chrome/chrome_tests.gypi: Declaring a runtime dependency isn't
   necessary since the trusted plugin isn't a separate DSO/DLL these
   days.

 * .gitignore: Remove reference to ppGoogleNaClPluginChrome.xml, which
   no longer exists.

 * module_ppapi.h: Added an #include guard.

BUG=239656
TEST=trybots

Committed: https://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f
Cr-Commit-Position: refs/heads/master@{#313759}

[Mark Seaborn, 2015-01-28 21:30:10]

mseaborn@chromium.org changed reviewers:
+ teravest@chromium.org

[teravest, 2015-01-28 21:57:25]

lgtm

After committing this, you'll probably want to clean up some paths in
native_client/pnacl/driver/pnacl-translate.py comments.

[jvoung (off chromium), 2015-01-28 22:18:16]

jvoung@chromium.org changed reviewers:
+ jvoung@chromium.org

[jvoung (off chromium), 2015-01-28 22:18:17]

cool!

https://codereview.chromium.org/876483002/diff/40001/components/nacl/renderer...
File components/nacl/renderer/plugin/module_ppapi.h (right):

https://codereview.chromium.org/876483002/diff/40001/components/nacl/renderer...
components/nacl/renderer/plugin/module_ppapi.h:6: 
Hmm never noticed that this doesn't have an include guard.

https://codereview.chromium.org/876483002/diff/40001/components/nacl/renderer...
File components/nacl/renderer/plugin/nacl_subprocess.h (right):

https://codereview.chromium.org/876483002/diff/40001/components/nacl/renderer...
components/nacl/renderer/plugin/nacl_subprocess.h:11: #ifndef
NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_NACL_SUBPROCESS_H_
Should the include guards be changed at some point too?

[Mark Seaborn, 2015-01-29 05:35:07]

https://codereview.chromium.org/876483002/diff/40001/components/nacl/renderer...
File components/nacl/renderer/plugin/module_ppapi.h (right):

https://codereview.chromium.org/876483002/diff/40001/components/nacl/renderer...
components/nacl/renderer/plugin/module_ppapi.h:6: 
On 2015/01/28 22:18:17, jvoung wrote:
> Hmm never noticed that this doesn't have an include guard.

Good point.  I've added one.

https://codereview.chromium.org/876483002/diff/40001/components/nacl/renderer...
File components/nacl/renderer/plugin/nacl_subprocess.h (right):

https://codereview.chromium.org/876483002/diff/40001/components/nacl/renderer...
components/nacl/renderer/plugin/nacl_subprocess.h:11: #ifndef
NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_NACL_SUBPROCESS_H_
On 2015/01/28 22:18:17, jvoung wrote:
> Should the include guards be changed at some point too?

Thanks for catching that.  Fixed.

[Mark Seaborn, 2015-01-29 05:36:12]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2015-01-29 05:37:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876483002/60001

[commit-bot: I haz the power, 2015-01-29 05:43:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-29 05:43:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mark Seaborn, 2015-01-29 05:51:54]

mseaborn@chromium.org changed reviewers:
+ jamescook@chromium.org, thakis@chromium.org

[Mark Seaborn, 2015-01-29 05:52:20]

For OWNERS sign-offs:
+thakis for chrome/
+jamescook for extensions/shell/

[Nico, 2015-01-29 05:56:58]

https://codereview.chromium.org/876483002/diff/60001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (left):

https://codereview.chromium.org/876483002/diff/60001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:2035: # Runtime dependency.
Is this no longer needed?

[Nico, 2015-01-29 05:57:19]

err nvm, explained in the cl description. chrome/ lgtm

[James Cook, 2015-01-29 19:17:24]

extensions/shell lgtm

[Mark Seaborn, 2015-01-29 19:34:22]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2015-01-29 19:34:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876483002/60001

[commit-bot: I haz the power, 2015-01-29 19:39:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-29 19:42:05]

Patchset 4 (id:??) landed as
https://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f
Cr-Commit-Position: refs/heads/master@{#313759}