Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 876433003: Fix JingleThreadWrapper initialization in PNaCl plugin. (Closed)

Created:
5 years, 11 months ago by Sergey Ulanov
Modified:
5 years, 11 months ago
Reviewers:
rmsousa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@db
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix JingleThreadWrapper initialization in PNaCl plugin. Previously JingleThreadWrapper was initialized in the remoting PNaCl plugin such that JingleThreadWrapper::current() was always returning NULL. JingleThreadWrapper::current() is used only to implement rtc::Thread::Send() and until recently Send() wasn't used in the parts of webrtc used in remoting. Now rtc::StunRequest uses Send(), which crashes the plugin. Added JingleThreadWrapper::WrapTaskRunner() that properly initializes current() and is used in the remoting plugin now. Also JingleThreadWrapper is no longer passes SocketServer to the parent as it is no longer necessary. BUG=451643 Committed: https://crrev.com/8eb15cc4766a09c82d0e4f60739b7675f23d4e60 Cr-Commit-Position: refs/heads/master@{#313213}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -24 lines) Patch
M jingle/glue/thread_wrapper.h View 2 chunks +10 lines, -5 lines 0 comments Download
M jingle/glue/thread_wrapper.cc View 6 chunks +27 lines, -17 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Sergey Ulanov
5 years, 11 months ago (2015-01-26 23:45:31 UTC) #7
rmsousa
lgtm https://codereview.chromium.org/876433003/diff/100001/remoting/client/plugin/chromoting_instance.cc File remoting/client/plugin/chromoting_instance.cc (right): https://codereview.chromium.org/876433003/diff/100001/remoting/client/plugin/chromoting_instance.cc#newcode201 remoting/client/plugin/chromoting_instance.cc:201: ProcessLogToUI("Initializing thread wrapper"); Is this a debugging leftover?
5 years, 11 months ago (2015-01-27 00:48:49 UTC) #8
Sergey Ulanov
https://codereview.chromium.org/876433003/diff/100001/remoting/client/plugin/chromoting_instance.cc File remoting/client/plugin/chromoting_instance.cc (right): https://codereview.chromium.org/876433003/diff/100001/remoting/client/plugin/chromoting_instance.cc#newcode201 remoting/client/plugin/chromoting_instance.cc:201: ProcessLogToUI("Initializing thread wrapper"); On 2015/01/27 00:48:48, rmsousa wrote: > ...
5 years, 11 months ago (2015-01-27 01:27:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876433003/120001
5 years, 11 months ago (2015-01-27 01:30:03 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:120001)
5 years, 11 months ago (2015-01-27 02:54:24 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 02:55:39 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8eb15cc4766a09c82d0e4f60739b7675f23d4e60
Cr-Commit-Position: refs/heads/master@{#313213}

Powered by Google App Engine
This is Rietveld 408576698