Issue 876353003: Use PNaCl's _Unwind_PNaClSetResult functions for arm-nacl-clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 876353003: Use PNaCl's _Unwind_PNaClSetResult functions for arm-nacl-clang (Closed)

Created:
5 years, 10 months ago by Derek Schuff

Modified:
5 years, 10 months ago

Reviewers:
jvoung (off chromium), JF

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-libcxxabi.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use PNaCl's _Unwind_PNaClSetResult functions for arm-nacl-clang For x86, the register values used by these functions match the __builtin_eh_return_data_regno builtins, so the native cxa_personality in libcxxabi matches the special unwinder built for PNaCl. However on ARM it does not. So as long as we are linking with the PNaCl uwinder we need to also use its API. R=jfb@chromium.org, jvoung@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=4018 Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-libcxxabi.git;a=commit;h=de05b63efeb5df83abe927c08f330c35995c82a7

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cxa_personality.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Derek Schuff

5 years, 10 months ago (2015-01-28 01:34:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
de05b63efeb5df83abe927c08f330c35995c82a7 (presubmit successful).