Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 876343002: Stabilize transition testcase. (Closed)

Created:
5 years, 11 months ago by Daniel Bratell
Modified:
5 years, 10 months ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Stabilize transition testcase. Roughly 1% of the times transitions/svg-visited-link-transitions.html runs it will set the "active" class before a previous layout. When that happens there won't be any style to animate so the elements reach the final step immediately. Fixed by forcing a layout pass before setting the "active" style. BUG=450497 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M LayoutTests/transitions/svg-visited-link-transitions.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Daniel Bratell
alancutter, can you please take a look?
5 years, 11 months ago (2015-01-27 15:26:34 UTC) #2
Timothy Loh
lgtm
5 years, 11 months ago (2015-01-28 00:52:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876343002/1
5 years, 10 months ago (2015-01-28 10:02:49 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 12:32:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189106

Powered by Google App Engine
This is Rietveld 408576698