Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 876313010: [Telemetry] Remove actions in RunPageInteractions for some of page_cycler's pages. (Closed)

Created:
5 years, 10 months ago by nednguyen
Modified:
5 years, 10 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove actions in RunPageInteractions for some of page_cycler's pages. This is needed so that page_cycler's action_name_to_run's field can later be changed from empty string to 'RunPageInteractions'. To reviewers: pages that have RunPageInteractions removed will be using the default implementation which does nothing. Those pages are only used by the page_cycler benchmark. BUG=418375 Committed: https://crrev.com/59e51dc126e93f6bc0779e115679e66374c5b848 Cr-Commit-Position: refs/heads/master@{#315417}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -41 lines) Patch
M tools/perf/benchmarks/page_cycler.py View 2 chunks +6 lines, -2 lines 0 comments Download
M tools/perf/page_sets/intl_ar_fa_he.py View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/perf/page_sets/intl_es_fr_pt-BR.py View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/perf/page_sets/intl_hi_ru.py View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/perf/page_sets/intl_ja_zh.py View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/perf/page_sets/intl_ko_th_vi.py View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/perf/page_sets/top_10_mobile.py View 3 chunks +6 lines, -3 lines 0 comments Download
M tools/perf/page_sets/tough_layout_cases.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
5 years, 10 months ago (2015-02-09 18:34:51 UTC) #2
sullivan
lgtm
5 years, 10 months ago (2015-02-09 20:11:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876313010/20001
5 years, 10 months ago (2015-02-09 20:45:39 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 22:42:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 22:44:20 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59e51dc126e93f6bc0779e115679e66374c5b848
Cr-Commit-Position: refs/heads/master@{#315417}

Powered by Google App Engine
This is Rietveld 408576698