Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 876203003: Don't navigate to destination on import. (Closed)

Created:
5 years, 10 months ago by Steve McKay
Modified:
5 years, 10 months ago
Reviewers:
Kyle Horimoto, Ben Kwa
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't navigate to destination on import. BUG=420680 TEST=browser_test: FileManagerJsTest.* Committed: https://crrev.com/b956dfdfe23fce187bbdc58c46cdf75cb73e5e36 Cr-Commit-Position: refs/heads/master@{#313571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -66 lines) Patch
M ui/file_manager/file_manager/foreground/js/import_controller.js View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller_unittest.js View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Steve McKay
5 years, 10 months ago (2015-01-28 18:22:43 UTC) #2
Ben Kwa
lgtm
5 years, 10 months ago (2015-01-28 19:30:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876203003/1
5 years, 10 months ago (2015-01-28 19:32:07 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-01-28 19:32:09 UTC) #7
Steve McKay
+Kyle, a committer.
5 years, 10 months ago (2015-01-28 19:39:45 UTC) #9
Kyle Horimoto
lgtm
5 years, 10 months ago (2015-01-28 19:40:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/876203003/1
5 years, 10 months ago (2015-01-28 19:41:59 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 20:30:10 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 20:32:42 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b956dfdfe23fce187bbdc58c46cdf75cb73e5e36
Cr-Commit-Position: refs/heads/master@{#313571}

Powered by Google App Engine
This is Rietveld 408576698