Issue 876203002: Turns out the CHECK I added for debugging can fail due to yet another bad side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 876203002: Turns out the CHECK I added for debugging can fail due to yet another bad side (Closed)

Created:
5 years, 11 months ago by Peter Kasting

Modified:
5 years, 11 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Turns out the CHECK I added for debugging can fail due to yet another bad side effect of the prerenderer not working right. Convert the CHECK into a conditional for now and leave an explanation of why it can fail. BUG=452299 TEST=none TBR=vitalybuka Committed: https://chromium.googlesource.com/chromium/src/+/c2308795c4125b11e13a0c5a4ed379b06ce156c3

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	chrome/browser/ui/omnibox/omnibox_navigation_observer.cc	View		1 chunk	+12 lines, -3 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/c2308795c4125b11e13a0c5a4ed379b06ce156c3 Cr-Commit-Position: refs/heads/master@{#313190}

5 years, 11 months ago (2015-01-27 01:25:32 UTC) #4

Peter Kasting

5 years, 11 months ago (2015-01-27 01:25:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c2308795c4125b11e13a0c5a4ed379b06ce156c3 (presubmit successful).