Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: src/IceTargetLowering.h

Issue 876083007: Subzero: Emit functions and global initializers in a separate thread. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: More code review changes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceGlobalContext.cpp ('k') | src/IceTargetLowering.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLowering.h
diff --git a/src/IceTargetLowering.h b/src/IceTargetLowering.h
index 2dda5c5126311ece3edf2416a43aded20ebdeee9..a9d3979dd8621a81726e8bc45b22eb676132ec5d 100644
--- a/src/IceTargetLowering.h
+++ b/src/IceTargetLowering.h
@@ -7,11 +7,13 @@
//
//===----------------------------------------------------------------------===//
//
-// This file declares the TargetLowering and LoweringContext
-// classes. TargetLowering is an abstract class used to drive the
-// translation/lowering process. LoweringContext maintains a
-// context for lowering each instruction, offering conveniences such
-// as iterating over non-deleted instructions.
+// This file declares the TargetLowering, LoweringContext, and
+// TargetDataLowering classes. TargetLowering is an abstract class
+// used to drive the translation/lowering process. LoweringContext
+// maintains a context for lowering each instruction, offering
+// conveniences such as iterating over non-deleted instructions.
+// TargetDataLowering is an abstract class used to drive the
+// lowering/emission of global initializers.
//
//===----------------------------------------------------------------------===//
@@ -247,12 +249,12 @@ class TargetDataLowering {
TargetDataLowering &operator=(const TargetDataLowering &) = delete;
public:
- static TargetDataLowering *createLowering(GlobalContext *Ctx);
+ static std::unique_ptr<TargetDataLowering> createLowering(GlobalContext *Ctx);
virtual ~TargetDataLowering();
virtual void lowerGlobal(const VariableDeclaration &Var) const = 0;
virtual void lowerGlobalsELF(const VariableDeclarationList &Vars) const = 0;
- virtual void lowerConstants(GlobalContext *Ctx) const = 0;
+ virtual void lowerConstants() const = 0;
protected:
TargetDataLowering(GlobalContext *Ctx) : Ctx(Ctx) {}
« no previous file with comments | « src/IceGlobalContext.cpp ('k') | src/IceTargetLowering.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698