Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 876083006: MIPS: Fix assertion in full codegen for holed 'this'. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1504 matching lines...) Expand 10 before | Expand all | Expand 10 after
1515 // 1515 //
1516 // The condition on the declaration scopes is a conservative check for 1516 // The condition on the declaration scopes is a conservative check for
1517 // nested functions that access a binding and are called before the 1517 // nested functions that access a binding and are called before the
1518 // binding is initialized: 1518 // binding is initialized:
1519 // function() { f(); let x = 1; function f() { x = 2; } } 1519 // function() { f(); let x = 1; function f() { x = 2; } }
1520 // 1520 //
1521 bool skip_init_check; 1521 bool skip_init_check;
1522 if (var->scope()->DeclarationScope() != scope()->DeclarationScope()) { 1522 if (var->scope()->DeclarationScope() != scope()->DeclarationScope()) {
1523 skip_init_check = false; 1523 skip_init_check = false;
1524 } else if (var->is_this()) { 1524 } else if (var->is_this()) {
1525 CHECK((info_->shared_info()->kind() & kSubclassConstructor) != 0); 1525 CHECK(info_->function() != nullptr &&
1526 (info_->function()->kind() & kSubclassConstructor) != 0);
1526 // TODO(dslomov): implement 'this' hole check elimination. 1527 // TODO(dslomov): implement 'this' hole check elimination.
1527 skip_init_check = false; 1528 skip_init_check = false;
1528 } else { 1529 } else {
1529 // Check that we always have valid source position. 1530 // Check that we always have valid source position.
1530 DCHECK(var->initializer_position() != RelocInfo::kNoPosition); 1531 DCHECK(var->initializer_position() != RelocInfo::kNoPosition);
1531 DCHECK(proxy->position() != RelocInfo::kNoPosition); 1532 DCHECK(proxy->position() != RelocInfo::kNoPosition);
1532 skip_init_check = var->mode() != CONST_LEGACY && 1533 skip_init_check = var->mode() != CONST_LEGACY &&
1533 var->initializer_position() < proxy->position(); 1534 var->initializer_position() < proxy->position();
1534 } 1535 }
1535 1536
(...skipping 3823 matching lines...) Expand 10 before | Expand all | Expand 10 after
5359 Assembler::target_address_at(pc_immediate_load_address)) == 5360 Assembler::target_address_at(pc_immediate_load_address)) ==
5360 reinterpret_cast<uint32_t>( 5361 reinterpret_cast<uint32_t>(
5361 isolate->builtins()->OsrAfterStackCheck()->entry())); 5362 isolate->builtins()->OsrAfterStackCheck()->entry()));
5362 return OSR_AFTER_STACK_CHECK; 5363 return OSR_AFTER_STACK_CHECK;
5363 } 5364 }
5364 5365
5365 5366
5366 } } // namespace v8::internal 5367 } } // namespace v8::internal
5367 5368
5368 #endif // V8_TARGET_ARCH_MIPS 5369 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698