Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 876023003: Dart: Changes to support building for Android. (Closed)

Created:
5 years, 11 months ago by zra
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Changes to support building for Android. This change builds and runs gen_snapshot using only the host toolchain, and so enables the Android build of Dart. It updates the Dart revision to pull in these changes: https://codereview.chromium.org/863173003/ BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/42969150f450c048c79dc0785e0d74b1c883a47c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/embedder/mojo_natives.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/dart/embedder/test/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/dart/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
zra
I couldn't quickly figure out how hack the test scripts to upload Dart code to ...
5 years, 11 months ago (2015-01-26 21:21:48 UTC) #2
abarth-chromium
On 2015/01/26 at 21:21:48, zra wrote: > I couldn't quickly figure out how hack the ...
5 years, 11 months ago (2015-01-26 21:24:54 UTC) #3
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-26 21:25:17 UTC) #4
zra
Committed patchset #1 (id:1) manually as 42969150f450c048c79dc0785e0d74b1c883a47c (presubmit successful).
5 years, 11 months ago (2015-01-26 22:47:56 UTC) #5
qsr
5 years, 10 months ago (2015-01-28 14:51:15 UTC) #6
Message was sent while issue was closed.
On 2015/01/26 21:24:54, abarth wrote:
> On 2015/01/26 at 21:21:48, zra wrote:
> > I couldn't quickly figure out how hack the test scripts to upload Dart code
to
> the device needed for dart_unittests. So this change does not enable any
> testing. @abarth, do you know who knows how to do that?
> 
> Generally speaking, we don't know now to run unittests on devices yet.  :)

 We do run unit tests on devices since last week. We will be running app test
when https://codereview.chromium.org/881753002/ lands. Now test have to be self
contained. We cannot run anything that depend on the source filesystem.

Powered by Google App Engine
This is Rietveld 408576698