Cross-process postMessage

chrome/browser/extensions/app_process_apitest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/process_map.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 134 matching lines @@
             browser()->GetTabContentsAt(3)->render_view_host()->process());
 
   // Now let's do the same using window.open. The same should happen.
   ASSERT_EQ(1u, BrowserList::GetBrowserCount(browser()->profile()));
   WindowOpenHelper(browser(), host,
                    base_url.Resolve("path1/empty.html"), true);
   LOG(INFO) << "WindowOpenHelper 1.";
   WindowOpenHelper(browser(), host,
                    base_url.Resolve("path2/empty.html"), true);
   LOG(INFO) << "WindowOpenHelper 2.";
-  // TODO(creis): This should open in a new process (i.e., false for the last
-  // argument), but we temporarily avoid swapping processes away from an app
-  // until we're able to support cross-process postMessage calls.
-  // See crbug.com/59285.
+  // This should open in a new process (i.e., false for the last argument).
   WindowOpenHelper(browser(), host,
-                   base_url.Resolve("path3/empty.html"), true);
+                   base_url.Resolve("path3/empty.html"), false);
   LOG(INFO) << "WindowOpenHelper 3.";
 
   // Now let's have these pages navigate, into or out of the extension web
   // extent. They should switch processes.
   const GURL& app_url(base_url.Resolve("path1/empty.html"));
   const GURL& non_app_url(base_url.Resolve("path3/empty.html"));
   NavigateTabHelper(browser()->GetTabContentsAt(2), non_app_url);
   LOG(INFO) << "NavigateTabHelper 1.";
   NavigateTabHelper(browser()->GetTabContentsAt(3), app_url);
   LOG(INFO) << "NavigateTabHelper 2.";
-  // TODO(creis): This should swap out of the app's process (i.e., EXPECT_NE),
-  // but we temporarily avoid swapping away from an app in case the window
-  // tries to send a postMessage to the app.  See crbug.com/59285.
-  EXPECT_EQ(host->process(),
+  EXPECT_NE(host->process(),
             browser()->GetTabContentsAt(2)->render_view_host()->process());
   EXPECT_EQ(host->process(),
             browser()->GetTabContentsAt(3)->render_view_host()->process());
 
   // If one of the popup tabs navigates back to the app, window.opener should
   // be valid.
   NavigateTabHelper(browser()->GetTabContentsAt(6), app_url);
   LOG(INFO) << "NavigateTabHelper 3.";
   EXPECT_EQ(host->process(),
             browser()->GetTabContentsAt(6)->render_view_host()->process());
@@ skipping 162 matching lines @@
   ASSERT_TRUE(test_server()->Start());
 
   ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("app_process")));
 
   // Open two tabs in the app.
   GURL base_url = GetTestBaseURL("app_process");
 
   browser()->NewTab();
   ui_test_utils::NavigateToURL(browser(), base_url.Resolve("path1/empty.html"));
   browser()->NewTab();
-  // Wait until the second tab finishes its redirect train (3 hops).
+  // Wait until the second tab finishes its redirect train (2 hops).
   // 1. We navigate to redirect.html
   // 2. Renderer navigates and finishes, counting as a load stop.
   // 3. Renderer issues the meta refresh to navigate to server-redirect.
   // 4. Renderer is now in a "provisional load", waiting for navigation to
   //    complete.
   // 5. Browser sees a redirect response from server-redirect to empty.html, and
   //    transfers that to a new navigation, using RequestTransferURL.
-  // 6. We navigate to empty.html.
-  // 7. Renderer is still in a provisional load to server-redirect, so that is
-  //    cancelled, and counts as a load stop
   // 8. Renderer navigates to empty.html, and finishes loading, counting as the
-  //    third load stop
+  //    second load stop
   ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
-      browser(), base_url.Resolve("path1/redirect.html"), 3);
+      browser(), base_url.Resolve("path1/redirect.html"), 2);
 
   // 3 tabs, including the initial about:blank. The last 2 should be the same
   // process.
   ASSERT_EQ(3, browser()->tab_count());
   EXPECT_EQ("/files/extensions/api_test/app_process/path1/empty.html",
             browser()->GetTabContentsAt(2)->controller().
                 GetLastCommittedEntry()->url().path());
   EXPECT_EQ(browser()->GetTabContentsAt(1)->render_view_host()->process(),
             browser()->GetTabContentsAt(2)->render_view_host()->process());
 }
@@ skipping 272 matching lines @@
           &browser()->GetSelectedTabContentsWrapper()->tab_contents()->
               controller()));
   browser()->Reload(CURRENT_TAB);
   observer.Wait();
   ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
       contents->render_view_host(), L"",
       L"window.domAutomationController.send(chrome.app.isInstalled)",
       &is_installed));
   ASSERT_TRUE(is_installed);
 }