Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: Source/WebCore/rendering/InlineIterator.h

Issue 8760017: Merge 101272 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/912/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/rendering/InlineIterator.h
===================================================================
--- Source/WebCore/rendering/InlineIterator.h (revision 101564)
+++ Source/WebCore/rendering/InlineIterator.h (working copy)
@@ -139,7 +139,8 @@
}
// FIXME: Should unicode-bidi: plaintext really be embedding override/embed characters here?
- observer->embed(embedCharFromDirection(style->direction(), unicodeBidi), FromStyleOrDOM);
+ if (!observer->inIsolate())
+ observer->embed(embedCharFromDirection(style->direction(), unicodeBidi), FromStyleOrDOM);
}
template <class Observer>
@@ -157,7 +158,8 @@
}
// Otherwise we pop any embed/override character we added when we opened this tag.
- observer->embed(WTF::Unicode::PopDirectionalFormat, FromStyleOrDOM);
+ if (!observer->inIsolate())
+ observer->embed(WTF::Unicode::PopDirectionalFormat, FromStyleOrDOM);
}
static inline bool isIteratorTarget(RenderObject* object)
Property changes on: Source\WebCore\rendering\InlineIterator.h
___________________________________________________________________
Added: svn:mergeinfo
Merged /trunk/WebCore/rendering/InlineIterator.h:r53455
« no previous file with comments | « LayoutTests/fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698