Issue 8760: Experimental regexp: Use new RegExp parser to test syntax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8760: Experimental regexp: Use new RegExp parser to test syntax. (Closed)

Created:
12 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Visibility:
Public.

Description

We still compile with JSCRE immediately, instead of at the first use.

Patch Set 1 #

Patch Set 2 : Use new RegExp parser to check syntax w/ review comments #

Patch Set 3 : Parses regexp using new parser. Rebased patch. #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -8 lines)			Patch
M	regexp2000/src/ast.h	View		11 chunks	+13 lines, -0 lines	0 comments	Download
M	regexp2000/src/ast.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	regexp2000/src/jsregexp.cc	View		5 chunks	+29 lines, -8 lines	0 comments	Download
M	regexp2000/src/objects.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	regexp2000/src/parser.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

12 years, 1 month ago (2008-10-31 08:52:14 UTC) #2

Lgtm!

http://codereview.chromium.org/8760/diff/1/5
File regexp2000/src/objects.h (right):

http://codereview.chromium.org/8760/diff/1/5#newcode2905
Line 2905: // NOT_COMPILED: A complex regexp for JSCRE that hasn't been compiled
yet.
As discussed I would use JSCRE for regexps that we know JSCRE should handle
independent of whether it has been compiled yet.  If we can it will be simpler
if tags are constant.

http://codereview.chromium.org/8760/diff/1/6
File regexp2000/src/parser.cc (right):

http://codereview.chromium.org/8760/diff/1/6#newcode3823
Line 3823: static const char* kRangeOutOfOrder = "range out of order in
character class";
I assume this error message reads the way it does for compatibility reasons.  I
suggest we introduce an incompatibility and start with an upper-case R.  All our
other error messages (withing regexps or not) start with an upper-case letter.

Expand Messages | Collapse Messages