Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 875993002: [Telemetry] Fix exception handling in user story runner. (Closed)

Created:
5 years, 11 months ago by nednguyen
Modified:
5 years, 11 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix exception handling in user story runner. Currently, unrecoverable exception raised during a user story run does not create a failure value for that user story. This leads to confusing log output by gtest_progress_reporter. This patch fixes this by catching unrecoverable exception and add failure value to the currently user story value. This patch also improve unittest in user_story_runner_unittest to make sure that the stdout output captures the raise exceptions. BUG=448827 Committed: https://crrev.com/326b32902255707e5a4154ed4db10f46c9fc8905 Cr-Commit-Position: refs/heads/master@{#313161}

Patch Set 1 : #

Patch Set 2 : Catch unhandlable exception & reraise instead of wrapping with UnrecoverableException #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -26 lines) Patch
M tools/telemetry/telemetry/user_story/user_story_runner.py View 1 2 chunks +5 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner_unittest.py View 1 6 chunks +31 lines, -25 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
nednguyen
5 years, 11 months ago (2015-01-26 18:17:11 UTC) #3
slamm
lgtm
5 years, 11 months ago (2015-01-26 18:22:23 UTC) #4
sullivan
lgtm
5 years, 11 months ago (2015-01-26 18:24:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875993002/20001
5 years, 11 months ago (2015-01-26 18:24:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/27159)
5 years, 11 months ago (2015-01-26 19:25:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875993002/20001
5 years, 11 months ago (2015-01-26 19:28:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/27159)
5 years, 11 months ago (2015-01-26 19:28:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875993002/20001
5 years, 11 months ago (2015-01-26 19:34:06 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/27194)
5 years, 11 months ago (2015-01-26 20:37:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875993002/40001
5 years, 11 months ago (2015-01-26 22:02:50 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 11 months ago (2015-01-26 22:58:32 UTC) #20
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 22:59:34 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/326b32902255707e5a4154ed4db10f46c9fc8905
Cr-Commit-Position: refs/heads/master@{#313161}

Powered by Google App Engine
This is Rietveld 408576698