Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 875983008: Revert "Only store leading 13 bits of password hash." (Closed)

Created:
5 years, 10 months ago by kozy
Modified:
5 years, 10 months ago
Reviewers:
Mike Lerman
CC:
chromium-reviews, tfarina, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Only store leading 13 bits of password hash." This reverts commit c511691cc06fd3a92f27e688795872e61efff40a. CL added SetUpgradeAndCheckCredentials test. This test failed on Mac 10.6 build bot. TBR=mlerman@chromium.org, NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/6bc9a331e82e4f94ca9e0f24eb0efa45ffc1e472 Cr-Commit-Position: refs/heads/master@{#314302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -232 lines) Patch
M chrome/browser/signin/chrome_signin_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/local_auth.h View 1 chunk +11 lines, -29 lines 0 comments Download
M chrome/browser/signin/local_auth.cc View 7 chunks +49 lines, -127 lines 0 comments Download
M chrome/browser/signin/local_auth_unittest.cc View 4 chunks +8 lines, -61 lines 0 comments Download
M chrome/browser/signin/signin_manager_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875983008/1
5 years, 10 months ago (2015-02-03 10:15:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 10:17:12 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 10:18:21 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bc9a331e82e4f94ca9e0f24eb0efa45ffc1e472
Cr-Commit-Position: refs/heads/master@{#314302}

Powered by Google App Engine
This is Rietveld 408576698