Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 875983006: Remove unused MSVS 2013 hack from base/numerics (Closed)

Created:
5 years, 11 months ago by jschuh
Modified:
5 years, 11 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused MSVS 2013 hack from base/numerics R=tsepez@chromium.org Committed: https://crrev.com/e0949ddadf5d0bd291c876f968f3c020b49f45e3 Cr-Commit-Position: refs/heads/master@{#313166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M base/numerics/safe_numerics_unittest.cc View 4 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jschuh
5 years, 11 months ago (2015-01-26 22:27:22 UTC) #1
Tom Sepez
RS LGTM on deleting unused code.
5 years, 11 months ago (2015-01-26 22:28:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875983006/1
5 years, 11 months ago (2015-01-26 22:45:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 23:31:15 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 23:32:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0949ddadf5d0bd291c876f968f3c020b49f45e3
Cr-Commit-Position: refs/heads/master@{#313166}

Powered by Google App Engine
This is Rietveld 408576698