Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issue 875953004: Add a basic sky-scrollable element that scrolls (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a basic sky-scrollable element that scrolls We still need to polish sky-scrollable, but it basically works. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a7e0a31f95c2a01981004c2c90614544045841f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -5 lines) Patch
A sky/examples/example-scrollable.sky View 1 chunk +42 lines, -0 lines 0 comments Download
A sky/framework/sky-scrollable.sky View 1 chunk +101 lines, -0 lines 0 comments Download
M sky/viewer/converters/input_event_types.cc View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 11 months ago (2015-01-26 19:43:01 UTC) #1
esprehn
lgtm
5 years, 11 months ago (2015-01-26 19:48:32 UTC) #2
abarth-chromium
5 years, 11 months ago (2015-01-26 21:29:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7e0a31f95c2a01981004c2c90614544045841f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698