Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 875913002: Alter gpu veto (Closed)

Created:
5 years, 11 months ago by robertphillips
Modified:
5 years, 11 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Alter gpu veto This CL unifies the treatment of the dashed and concave paths. Before: TP 28 FP 15 TN 8 FN 3 IND 3 After: TP 28 FP 18 TN 7 FN 2 IND 2 One of the TrueNegatives that became a FalsePositive was the motivation use case (the Chromium busy spinner). Committed: https://skia.googlesource.com/skia/+/87a6a8e18c7d5bbc94f478b44c53dc0e0549f927 Committed: https://skia.googlesource.com/skia/+/98b0315ad6beb7dbc311fd365ffe5c24d7ef2d0f

Patch Set 1 #

Patch Set 2 : Fix PictureTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M src/core/SkPicture.cpp View 1 chunk +12 lines, -21 lines 0 comments Download
M tests/PictureTest.cpp View 1 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
robertphillips
5 years, 11 months ago (2015-01-26 14:15:26 UTC) #2
robertphillips
5 years, 11 months ago (2015-01-26 14:29:36 UTC) #4
bsalomon
lgtm
5 years, 11 months ago (2015-01-26 14:34:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875913002/1
5 years, 11 months ago (2015-01-26 14:44:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/87a6a8e18c7d5bbc94f478b44c53dc0e0549f927
5 years, 11 months ago (2015-01-26 14:53:08 UTC) #8
robertphillips
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/879483003/ by robertphillips@google.com. ...
5 years, 11 months ago (2015-01-26 15:04:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875913002/20001
5 years, 11 months ago (2015-01-26 15:51:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875913002/20001
5 years, 11 months ago (2015-01-26 19:09:31 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 19:29:40 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/98b0315ad6beb7dbc311fd365ffe5c24d7ef2d0f

Powered by Google App Engine
This is Rietveld 408576698