Rescale histogram timers.

src/counters.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COUNTERS_H_
 #define V8_COUNTERS_H_
 
 #include "include/v8.h"
 #include "src/allocation.h"
 #include "src/base/platform/elapsed-timer.h"
@@ skipping 297 matching lines @@
 //     events to be timed.
 class AggregatableHistogramTimer : public Histogram {
  public:
   AggregatableHistogramTimer() {}
   AggregatableHistogramTimer(const char* name, int min, int max,
                              int num_buckets, Isolate* isolate)
       : Histogram(name, min, max, num_buckets, isolate) {}
 
   // Start/stop the "outer" scope.
   void Start() { time_ = base::TimeDelta(); }
-  void Stop() { AddSample(static_cast<int>(time_.InMilliseconds())); }
+  void Stop() { AddSample(static_cast<int>(time_.InMicroseconds())); }
 
   // Add a time value ("inner" scope).
   void Add(base::TimeDelta other) { time_ += other; }
 
  private:
   base::TimeDelta time_;
 };
 
 
 // A helper class for use with AggregatableHistogramTimer.
@@ skipping 24 matching lines @@
   AggregatableHistogramTimer* histogram_;
 };
 
 
 #define HISTOGRAM_RANGE_LIST(HR)                                              \
   /* Generic range histograms */                                              \
   HR(gc_idle_time_allotted_in_ms, V8.GCIdleTimeAllottedInMS, 0, 10000, 101)   \
   HR(gc_idle_time_limit_overshot, V8.GCIdleTimeLimit.Overshot, 0, 10000, 101) \
   HR(gc_idle_time_limit_undershot, V8.GCIdleTimeLimit.Undershot, 0, 10000, 101)
 
-#define HISTOGRAM_TIMER_LIST(HT)                             \
-  /* Garbage collection timers. */                           \
-  HT(gc_compactor, V8.GCCompactor)                           \
-  HT(gc_scavenger, V8.GCScavenger)                           \
-  HT(gc_context, V8.GCContext) /* GC context cleanup time */ \
-  HT(gc_idle_notification, V8.GCIdleNotification)            \
-  HT(gc_incremental_marking, V8.GCIncrementalMarking)        \
-  HT(gc_low_memory_notification, V8.GCLowMemoryNotification) \
-  /* Parsing timers. */                                      \
-  HT(parse, V8.Parse)                                        \
-  HT(parse_lazy, V8.ParseLazy)                               \
-  HT(pre_parse, V8.PreParse)                                 \
-  /* Compilation times. */                                   \
-  HT(compile, V8.Compile)                                    \
-  HT(compile_eval, V8.CompileEval)                           \
-  /* Serialization as part of compilation (code caching) */  \
-  HT(compile_serialize, V8.CompileSerialize)                 \
-  HT(compile_deserialize, V8.CompileDeserialize)             \
-  /* Total compilation time incl. caching/parsing */         \
-  HT(compile_script, V8.CompileScript)
+#define SECONDS *1000 * 1000
+#define MILLISECONDS *1000

[vogelheim, 2015/01/26 14:46:50]

I'm not super fond of this style of macro meta programming, but I guess this is
personal preference. I think I'd prefer either plain const expressions for the
conversion factors or at least macros with parameters (that is, SECONDS(10)).

Not a big deal though, so please decide as you see fit.

[Yang, 2015/01/26 15:09:07]

Done.

+
+#define HISTOGRAM_TIMER_LIST(HT)                                         \
+  /* Garbage collection timers. */                                       \
+  HT(gc_compactor, V8.GCCompactor, 10 SECONDS)                           \
+  HT(gc_scavenger, V8.GCScavenger, 10 SECONDS)                           \
+  HT(gc_context, V8.GCContext, 10 SECONDS) /* GC context cleanup time */ \
+  HT(gc_idle_notification, V8.GCIdleNotification, 10 SECONDS)            \
+  HT(gc_incremental_marking, V8.GCIncrementalMarking, 10 SECONDS)        \
+  HT(gc_low_memory_notification, V8.GCLowMemoryNotification, 10 SECONDS) \
+  /* Parsing timers. */                                                  \
+  HT(parse, V8.Parse, 1000 MILLISECONDS)                                 \
+  HT(parse_lazy, V8.ParseLazy, 1000 MILLISECONDS)                        \
+  HT(pre_parse, V8.PreParse, 1000 MILLISECONDS)                          \
+  /* Compilation times. */                                               \
+  HT(compile, V8.Compile, 1000 MILLISECONDS)                             \
+  HT(compile_eval, V8.CompileEval, 1000 MILLISECONDS)                    \
+  /* Serialization as part of compilation (code caching) */              \
+  HT(compile_serialize, V8.CompileSerialize, 100 MILLISECONDS)           \
+  HT(compile_deserialize, V8.CompileDeserialize, 100 MILLISECONDS)       \
+  /* Total compilation time incl. caching/parsing */                     \
+  HT(compile_script, V8.CompileScript, 1000 MILLISECONDS)
+
+#undef SECONDS
+#undef MILLISECONDS
 
 
 #define AGGREGATABLE_HISTOGRAM_TIMER_LIST(AHT) \
   AHT(compile_lazy, V8.CompileLazy)
 
 
 #define HISTOGRAM_PERCENTAGE_LIST(HP)                                 \
   /* Heap fragmentation. */                                           \
   HP(external_fragmentation_total,                                    \
      V8.MemoryExternalFragmentationTotal)                             \
@@ skipping 231 matching lines @@
 
 
 // This file contains all the v8 counters that are in use.
 class Counters {
  public:
 #define HR(name, caption, min, max, num_buckets) \
   Histogram* name() { return &name##_; }
   HISTOGRAM_RANGE_LIST(HR)
 #undef HR
 
-#define HT(name, caption) \
+#define HT(name, caption, scale) \
   HistogramTimer* name() { return &name##_; }
   HISTOGRAM_TIMER_LIST(HT)
 #undef HT
 
 #define AHT(name, caption) \
   AggregatableHistogramTimer* name() { return &name##_; }
   AGGREGATABLE_HISTOGRAM_TIMER_LIST(AHT)
 #undef AHT
 
 #define HP(name, caption) \
@@ skipping 36 matching lines @@
 
 #define SC(name) \
   StatsCounter* count_of_CODE_AGE_##name() \
     { return &count_of_CODE_AGE_##name##_; } \
   StatsCounter* size_of_CODE_AGE_##name() \
     { return &size_of_CODE_AGE_##name##_; }
   CODE_AGE_LIST_COMPLETE(SC)
 #undef SC
 
   enum Id {
-#define RATE_ID(name, caption) k_##name,
+#define RATE_ID(name, caption, scale) k_##name,
     HISTOGRAM_TIMER_LIST(RATE_ID)
 #undef RATE_ID
 #define AGGREGATABLE_ID(name, caption) k_##name,
-    AGGREGATABLE_HISTOGRAM_TIMER_LIST(AGGREGATABLE_ID)
+        AGGREGATABLE_HISTOGRAM_TIMER_LIST(AGGREGATABLE_ID)
 #undef AGGREGATABLE_ID
 #define PERCENTAGE_ID(name, caption) k_##name,
-    HISTOGRAM_PERCENTAGE_LIST(PERCENTAGE_ID)
+            HISTOGRAM_PERCENTAGE_LIST(PERCENTAGE_ID)
 #undef PERCENTAGE_ID
 #define MEMORY_ID(name, caption) k_##name,
-    HISTOGRAM_MEMORY_LIST(MEMORY_ID)
+                HISTOGRAM_MEMORY_LIST(MEMORY_ID)
 #undef MEMORY_ID
 #define COUNTER_ID(name, caption) k_##name,
-    STATS_COUNTER_LIST_1(COUNTER_ID)
-    STATS_COUNTER_LIST_2(COUNTER_ID)
+                    STATS_COUNTER_LIST_1(COUNTER_ID) STATS_COUNTER_LIST_2(
+                        COUNTER_ID)
 #undef COUNTER_ID
 #define COUNTER_ID(name) kCountOf##name, kSizeOf##name,
-    INSTANCE_TYPE_LIST(COUNTER_ID)
+                        INSTANCE_TYPE_LIST(COUNTER_ID)
 #undef COUNTER_ID
 #define COUNTER_ID(name) kCountOfCODE_TYPE_##name, \
     kSizeOfCODE_TYPE_##name,
-    CODE_KIND_LIST(COUNTER_ID)
+                            CODE_KIND_LIST(COUNTER_ID)
 #undef COUNTER_ID
 #define COUNTER_ID(name) kCountOfFIXED_ARRAY__##name, \
     kSizeOfFIXED_ARRAY__##name,
-    FIXED_ARRAY_SUB_INSTANCE_TYPE_LIST(COUNTER_ID)
+                                FIXED_ARRAY_SUB_INSTANCE_TYPE_LIST(COUNTER_ID)
 #undef COUNTER_ID
 #define COUNTER_ID(name) kCountOfCODE_AGE__##name, \
     kSizeOfCODE_AGE__##name,
-    CODE_AGE_LIST_COMPLETE(COUNTER_ID)
+                                    CODE_AGE_LIST_COMPLETE(COUNTER_ID)
 #undef COUNTER_ID
-    stats_counter_count
+                                        stats_counter_count

[vogelheim, 2015/01/26 14:46:50]

This (and above) is a super strange indent.

I take it this is clang-format. The same occured on my recent CL in the file,
and I just reverted these (local) changes and rather ignored clang-format than
mess up the code.

Not sure if there's a policy for this.

[Yang, 2015/01/26 15:09:07]

Done.

   };
 
   void ResetCounters();
   void ResetHistograms();
 
  private:
 #define HR(name, caption, min, max, num_buckets) Histogram name##_;
   HISTOGRAM_RANGE_LIST(HR)
 #undef HR
 
-#define HT(name, caption) \
-  HistogramTimer name##_;
+#define HT(name, caption, scale) HistogramTimer name##_;
   HISTOGRAM_TIMER_LIST(HT)
 #undef HT
 
 #define AHT(name, caption) \
   AggregatableHistogramTimer name##_;
   AGGREGATABLE_HISTOGRAM_TIMER_LIST(AHT)
 #undef AHT
 
 #define HP(name, caption) \
   Histogram name##_;
@@ skipping 38 matching lines @@
   friend class Isolate;
 
   explicit Counters(Isolate* isolate);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(Counters);
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_COUNTERS_H_