Rescale histogram timers.

src/counters.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/base/platform/platform.h"
 #include "src/counters.h"
 #include "src/isolate.h"
 #include "src/log-inl.h"
@@ skipping 29 matching lines @@
   if (Enabled()) {
     timer_.Start();
   }
   Logger::CallEventLogger(isolate(), name(), Logger::START, true);
 }
 
 
 // Stop the timer and record the results.
 void HistogramTimer::Stop() {
   if (Enabled()) {
-    // Compute the delta between start and stop, in milliseconds.
-    AddSample(static_cast<int>(timer_.Elapsed().InMilliseconds()));
+    // Compute the delta between start and stop, in microseconds.
+    AddSample(static_cast<int>(timer_.Elapsed().InMicroseconds()));
     timer_.Stop();
   }
   Logger::CallEventLogger(isolate(), name(), Logger::END, true);
 }
 
 
 Counters::Counters(Isolate* isolate) {
 #define HR(name, caption, min, max, num_buckets) \
   name##_ = Histogram(#caption, min, max, num_buckets, isolate);
   HISTOGRAM_RANGE_LIST(HR)
 #undef HR
 
-#define HT(name, caption) \
-    name##_ = HistogramTimer(#caption, 0, 10000, 50, isolate);
+#define HT(name, caption, max) \
+  name##_ = HistogramTimer(#caption, 0, max, 50, isolate);
     HISTOGRAM_TIMER_LIST(HT)
 #undef HT
 
 #define AHT(name, caption) \
-  name##_ = AggregatableHistogramTimer(#caption, 0, 10000, 50, isolate);
+  name##_ = AggregatableHistogramTimer(#caption, 0, 1000000, 50, isolate);

[vogelheim, 2015/01/26 14:46:50]

One more '0' please. Compile times in single digit seconds aren't unheard of, so
I think the counter should go to 10s, as it previously did.

[Yang, 2015/01/26 15:09:07]

Done.

     AGGREGATABLE_HISTOGRAM_TIMER_LIST(AHT)
 #undef AHT
 
 #define HP(name, caption) \
     name##_ = Histogram(#caption, 0, 101, 100, isolate);
     HISTOGRAM_PERCENTAGE_LIST(HP)
 #undef HP
 
 #define HM(name, caption) \
     name##_ = Histogram(#caption, 1000, 500000, 50, isolate);
@@ skipping 69 matching lines @@
   CODE_AGE_LIST_COMPLETE(SC)
 #undef SC
 }
 
 
 void Counters::ResetHistograms() {
 #define HR(name, caption, min, max, num_buckets) name##_.Reset();
   HISTOGRAM_RANGE_LIST(HR)
 #undef HR
 
-#define HT(name, caption) name##_.Reset();
+#define HT(name, caption, max) name##_.Reset();
     HISTOGRAM_TIMER_LIST(HT)
 #undef HT
 
 #define AHT(name, caption) name##_.Reset();
     AGGREGATABLE_HISTOGRAM_TIMER_LIST(AHT)
 #undef AHT
 
 #define HP(name, caption) name##_.Reset();
     HISTOGRAM_PERCENTAGE_LIST(HP)
 #undef HP
 
 #define HM(name, caption) name##_.Reset();
     HISTOGRAM_MEMORY_LIST(HM)
 #undef HM
 }
 
 } }  // namespace v8::internal