Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: sky/framework/xmlhttprequest.sky

Issue 875713003: Upgrade Sky's use of the JS bindings (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/framework/shell.sky ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/xmlhttprequest.sky
diff --git a/sky/framework/xmlhttprequest.sky b/sky/framework/xmlhttprequest.sky
index ef132650cada24ed1f44aac58a35d9ec30c84f2e..7df72b17532d6681a50e1d1f266688921c33a6d2 100644
--- a/sky/framework/xmlhttprequest.sky
+++ b/sky/framework/xmlhttprequest.sky
@@ -101,10 +101,9 @@ class XMLHttpRequest {
});
priv.request.headers = requestHeaders;
- // FIXME: Factor this into the JS bindings.
- var pipe = new core.createMessagePipe();
- priv.networkService.createURLLoader(pipe.handle1);
- priv.loader = shell.wrapHandle(pipe.handle0, loader.URLLoader);
+ priv.networkService.createURLLoader(function(urlLoaderProxy) {
+ priv.loader = urlLoaderProxy;
+ });
var self = this;
outstandingRequests.add(this);
« no previous file with comments | « sky/framework/shell.sky ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698