Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: services/file_manager/file.mojom

Issue 875643004: Prototype of Files service. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: wipwipwip Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/file_manager/file.mojom
diff --git a/services/file_manager/file.mojom b/services/file_manager/file.mojom
new file mode 100644
index 0000000000000000000000000000000000000000..bb2915a7611e5fae99b1941bde72ad55c50e8da1
--- /dev/null
+++ b/services/file_manager/file.mojom
@@ -0,0 +1,50 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+//FIXME FIXME FIXME: notes to self:
+// - file offsets, file positions, and file sizes are int64 (though positions
+// and sizes must always be non-negative)
+// - buffer size parameters (for read/write) are uint32
+// - timestamps are int64, milliseconds since Unix epoch (i.e., dubious)
+
+module mojo.files;
+
+import "services/file_manager/types.mojom";
+
+interface File {
+ Close() => (Error err);
+
+ Read(uint32 num_bytes_to_read, int64 offset, Whence whence)
+ => (Error error, array<uint8>? bytes_read);
+ Write(array<uint8> bytes_to_write, int64 offset, Whence whence)
+ => (Error error, uint32 num_bytes_written);
+
+ ReadStream(handle<data_pipe_producer> source, int64 offset, Whence whence)
qsr 2015/02/06 10:54:55 When does those returns in a non error case? When
viettrungluu 2015/02/06 16:57:36 Hmmm, that's a good question. I was imagining tha
+ => (Error error);
+ WriteStream(handle<data_pipe_consumer> sink, int64 offset, Whence whence)
+ => (Error error);
+
+ Tell() => (Error error, int64 position);
+ Seek(int64 offset, Whence whence) => (Error error, int64 position);
+
+ Stat() => (Error error, FileInformation? file_information);
+ Truncate(int64 size) => (Error error);
+ // TODO(vtl): null |times| means "now" (for both atime and mtime).
+ Touch(FileTimes? times) => (Error error);
+
+ // TODO(vtl): |Dup()| shares the same file description (i.e., mode and
+ // position).
+ Dup(File& file) => (Error error);
+ // TODO(vtl): What are the rules for reopening (w.r.t. changing mode/flags).
+ // E.g., obviously can go from "read-write" to "read", but reverse? (probably
+ // not), can remove "append"? (probably not?). Do we allow "truncate"?
+ Reopen(File& file, uint32 access_flags, uint32 open_flags)
+ => (Error error);
abarth-chromium 2015/02/06 04:38:35 I imagine we'll want to be able to pass Files to o
viettrungluu 2015/02/06 06:20:41 Right. The more confusing ones are "append", etc.
+
+ // TODO(vtl): probably should have access flags (but also exec?); how do these
+ // relate to access mode?
+ AsBuffer() => (Error error, handle<shared_buffer>? buffer);
+
+ // TODO(vtl): Add a "watch"?
+};

Powered by Google App Engine
This is Rietveld 408576698