Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 875643003: asan/win: Add runtime library to isolate. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M base/base.isolate View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
See bug. Medium-term, we might want to copy this dll to the build directory and ...
5 years, 11 months ago (2015-01-24 19:30:54 UTC) #2
Nico
I'm going to land this and see what happens. From my current understanding, it shouldn't ...
5 years, 11 months ago (2015-01-24 19:44:14 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/433d44af3ab11583fa8052af9282ce9de7527ee9 Cr-Commit-Position: refs/heads/master@{#313029}
5 years, 11 months ago (2015-01-24 19:49:45 UTC) #4
Nico
Committed patchset #1 (id:1) manually as 433d44af3ab11583fa8052af9282ce9de7527ee9 (presubmit successful).
5 years, 11 months ago (2015-01-24 19:49:59 UTC) #5
Timur Iskhodzhanov
5 years, 11 months ago (2015-01-26 12:57:44 UTC) #6
Message was sent while issue was closed.
LGTM

Probably we need to do the same trick for the ASan DLL thunk (static build)

Powered by Google App Engine
This is Rietveld 408576698