Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 875613002: Create setup and arrange duplicated the following lines for Issue 443821 (Closed)

Created:
5 years, 11 months ago by Jimmy Jo
Modified:
5 years, 11 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create setup and arrange duplicated the following lines for Issue 443821 StateMachine state(scheduler_settings); state.SetCanStart(); state.UpdateState(state.NextAction()); state.CreateAndInitializeOutputSurfaceWithActivatedCommit(); state.SetVisible(true); state.SetCanDraw(true); BUG=443821 Committed: https://crrev.com/5ed0df28fb122843bf65a1084b0c971c5e083410 Cr-Commit-Position: refs/heads/master@{#313199}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : modify some argument by sunnyps`s guide #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -153 lines) Patch
M cc/scheduler/scheduler_state_machine_unittest.cc View 1 31 chunks +37 lines, -153 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Jimmy Jo
PTAL!!
5 years, 11 months ago (2015-01-24 07:36:33 UTC) #7
sunnyps
https://codereview.chromium.org/875613002/diff/100001/cc/scheduler/scheduler_state_machine_unittest.cc File cc/scheduler/scheduler_state_machine_unittest.cc (right): https://codereview.chromium.org/875613002/diff/100001/cc/scheduler/scheduler_state_machine_unittest.cc#newcode52 cc/scheduler/scheduler_state_machine_unittest.cc:52: #define SET_UP_STATE(state, visible, can_draw) \ There's really no need ...
5 years, 11 months ago (2015-01-25 03:27:33 UTC) #9
Jimmy Jo
https://codereview.chromium.org/875613002/diff/100001/cc/scheduler/scheduler_state_machine_unittest.cc File cc/scheduler/scheduler_state_machine_unittest.cc (right): https://codereview.chromium.org/875613002/diff/100001/cc/scheduler/scheduler_state_machine_unittest.cc#newcode52 cc/scheduler/scheduler_state_machine_unittest.cc:52: #define SET_UP_STATE(state, visible, can_draw) \ On 2015/01/25 03:27:33, sunnyps ...
5 years, 11 months ago (2015-01-25 06:05:09 UTC) #10
sunnyps
On 2015/01/25 06:05:09, Jincheol Jo wrote: > https://codereview.chromium.org/875613002/diff/100001/cc/scheduler/scheduler_state_machine_unittest.cc > File cc/scheduler/scheduler_state_machine_unittest.cc (right): > > https://codereview.chromium.org/875613002/diff/100001/cc/scheduler/scheduler_state_machine_unittest.cc#newcode52 ...
5 years, 11 months ago (2015-01-26 19:48:45 UTC) #11
brianderson
lgtm. Thank Jincheol.
5 years, 11 months ago (2015-01-27 00:51:32 UTC) #12
Jimmy Jo
On 2015/01/27 00:51:32, brianderson wrote: > lgtm. Thank Jincheol. Thank sunny, brian.
5 years, 11 months ago (2015-01-27 00:57:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875613002/120001
5 years, 11 months ago (2015-01-27 00:58:20 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:120001)
5 years, 11 months ago (2015-01-27 01:48:54 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 01:49:40 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ed0df28fb122843bf65a1084b0c971c5e083410
Cr-Commit-Position: refs/heads/master@{#313199}

Powered by Google App Engine
This is Rietveld 408576698