Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: remoting/webapp/crd/js/event_handlers.js

Issue 875583002: Allow full-screen mode when not connected, and remember the previous setting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/event_handlers.js
diff --git a/remoting/webapp/crd/js/event_handlers.js b/remoting/webapp/crd/js/event_handlers.js
index f6b86d2c42d5d4ffa036255d121ccebed972fe97..41b562faf99851d0f0111c12b452a420707d3c48 100644
--- a/remoting/webapp/crd/js/event_handlers.js
+++ b/remoting/webapp/crd/js/event_handlers.js
@@ -9,12 +9,6 @@ var remoting = remoting || {};
remoting.initGlobalEventHandlers = function() {
window.addEventListener('resize', remoting.onResize, false);
- // When a window goes full-screen, a resize event is triggered, but the
- // Fullscreen.isActive call is not guaranteed to return true until the
- // full-screen event is triggered. In apps v2, the size of the window's
- // client area is calculated differently in full-screen mode, so register
- // for both events.
- remoting.fullscreen.addListener(remoting.onResize);
Jamie 2015/01/23 22:37:24 This needed to be moved because remoting.fullscree
kelvinp 2015/01/23 23:39:58 I think we should also move both handlers (window.
Jamie 2015/01/24 00:46:35 Done. I've also moved the two remaining lines out
if (!base.isAppsV2()) {
window.addEventListener('beforeunload', remoting.promptClose, false);
window.addEventListener('unload', remoting.disconnect, false);

Powered by Google App Engine
This is Rietveld 408576698