Allow full-screen mode when not connected, and remember the previous setting.

remoting/webapp/crd/js/event_handlers.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 remoting.initGlobalEventHandlers = function() {
   window.addEventListener('resize', remoting.onResize, false);
-  // When a window goes full-screen, a resize event is triggered, but the
-  // Fullscreen.isActive call is not guaranteed to return true until the
-  // full-screen event is triggered. In apps v2, the size of the window's
-  // client area is calculated differently in full-screen mode, so register
-  // for both events.
-  remoting.fullscreen.addListener(remoting.onResize);

[Jamie, 2015/01/23 22:37:24]

This needed to be moved because remoting.fullscreen is now created later than it
was previously. I think the new location makes more sense, since it's only
needed for CRD.

[kelvinp, 2015/01/23 23:39:58]

I think we should also move both handlers (window.resize and fullscreen) at the
same time, otherwise it would be hard to follow the comments when it says 'both'
events.

If we are moving the handlers anyways, can we simply move it to the place when
remoting.clientSession is set.  However, looking at the code, it is probably
hard to do that now, as remoting.clientSession is currently set in one place but
tear down in another, which would require some refactoring.

[Jamie, 2015/01/24 00:46:35]

Done. I've also moved the two remaining lines out of this method, since they're
apps v1 only, and deleted the method entirely.

   if (!base.isAppsV2()) {
     window.addEventListener('beforeunload', remoting.promptClose, false);
     window.addEventListener('unload', remoting.disconnect, false);
   }
 }
 
 /**
  * @param {Array.<{event: string, id: string,
  *     fn: function(Event):void}>} actions Array of actions to register.
  */
@@ skipping 13 matching lines @@
 function registerEventListener(id, eventname, fn) {
   var element = document.getElementById(id);
   if (element) {
     element.addEventListener(eventname, fn, false);
   } else {
     console.error('Could not set ' + eventname +
         ' event handler on element ' + id +
         ': element not found.');
   }
 }