Allow full-screen mode when not connected, and remember the previous setting.

remoting/webapp/crd/js/app_launcher.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * AppLauncher is an interface that allows the client code to launch and close
  * the app without knowing the implementation difference between a v1 app and
  * a v2 app.
  *
@@ skipping 87 matching lines @@
 remoting.V2AppLauncher.nextWindowId_ = 0;
 
 remoting.V2AppLauncher.prototype.launch = function(opt_launchArgs) {
   var url = base.urlJoin('main.html', opt_launchArgs);
 
   /**
    * @param {function(*=):void} resolve
    * @param {function(*=):void} reject
    */
   return new Promise(function(resolve, reject) {
-    chrome.app.window.create(url, {
-        'width': 800,
-        'height': 600,
-        'frame': 'none',
-        'id': String(remoting.V2AppLauncher.nextWindowId_++)
-      },
-      /** @param {AppWindow=} appWindow */
-      function(appWindow) {
-        if (!appWindow) {
-          reject(new Error(chrome.runtime.lastError.message));
-        } else {
-          resolve(appWindow.id);
-        }
-      });
+    var START_FULLSCREEN = 'start-fullscreen';
+    /** @param {Object} values */
+    var onValues = function(values) {
+      /** @type {string} */
+      var state = values[START_FULLSCREEN] ? 'fullscreen' : 'normal';

[Jamie, 2015/01/23 22:37:24]

As discussed, this currently doesn't work due to crbug.com/51587.

[kelvinp, 2015/01/23 23:39:58]

Should we wait for the apps team before making this change as they may come back
with by design and then we would need to do the workaround instead of this code?

[Jamie, 2015/01/24 00:46:35]

I decided to go ahead and implement the workaround anyway, since there isn't
much value to this CL without it (just enabling the full-screen button before
you connect to a host).

+      chrome.app.window.create(url, {
+          'width': 800, 'height': 600,
+          'frame': 'none',
+          'id': String(remoting.V2AppLauncher.nextWindowId_++),
+          'state': state
+        },
+        /** @param {AppWindow=} appWindow */
+        function(appWindow) {
+          if (!appWindow) {
+            reject(new Error(chrome.runtime.lastError.message));
+          } else {
+            resolve(appWindow.id);
+          }
+        });
+    };
+    chrome.storage.local.get(START_FULLSCREEN, onValues);
   });
 };
 
 remoting.V2AppLauncher.prototype.close = function(id) {
   var appWindow = chrome.app.window.get(id);
   if (!appWindow) {
     return Promise.reject(new Error(chrome.runtime.lastError.message));
   }
   appWindow.close();
   return Promise.resolve();
 };