Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 875573004: ozone: Fix chromium-style warnings in rendering_helper.cc (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
Reviewers:
Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Fix chromium-style warnings in rendering_helper.cc This fixes the linux_chromium_chromeos_ozone_rel_ng bot: ../../content/common/gpu/media/rendering_helper.cc:105:31: error: [chromium-style] Overriding method must be marked with 'override' or 'final'. virtual ~StubOzoneDelegate() {} ^ override TBR=posciak (red build) NOTRY=true BUG=none TEST=linux_chromium_chromeos_ozone_rel_ng trybot Committed: https://crrev.com/2334c429f4dbe958167ca8e5ab545efb11610951 Cr-Commit-Position: refs/heads/master@{#313763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/gpu/media/rendering_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
5 years, 10 months ago (2015-01-29 19:28:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875573004/1
5 years, 10 months ago (2015-01-29 19:49:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 19:50:45 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2334c429f4dbe958167ca8e5ab545efb11610951 Cr-Commit-Position: refs/heads/master@{#313763}
5 years, 10 months ago (2015-01-29 19:51:28 UTC) #6
Pawel Osciak
5 years, 10 months ago (2015-01-30 04:18:48 UTC) #7
Message was sent while issue was closed.
lgtm thanks

Powered by Google App Engine
This is Rietveld 408576698