Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 875523002: Reenable event_unittests with a hack. (Closed)

Created:
5 years, 11 months ago by Elliot Glaysher
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Reenable event_unittests. The changes that make the gn files match the gyp files have been rolled from the Chromium repository and the event_unittests now work in Linux ASAN mode. BUG=452105 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/193e68613ff439d2068313eac9c49320f72a61a1

Patch Set 1 #

Patch Set 2 : Upload half the unit tests. #

Patch Set 3 : Disable more tests #

Patch Set 4 : Make the unit tests binary empty. #

Patch Set 5 : And try removing event test support. #

Patch Set 6 : minus more dependencies #

Patch Set 7 : remove events platform #

Patch Set 8 : and remove all events libraries. #

Patch Set 9 : This is getting really bizzare. #

Patch Set 10 : Try removing base. #

Patch Set 11 : No linux:x11 #

Patch Set 12 : Minus skia. #

Patch Set 13 : add a printf at the start of run_all_unittests.cc #

Patch Set 14 : lrn2c #

Patch Set 15 : Lots of fprintfs. #

Patch Set 16 : more fprintfs #

Patch Set 17 : Update the fprintf because omg that is weird to error there. #

Patch Set 18 : fprintf in time_posix. #

Patch Set 19 : Remove -Wl,--as-needed #

Patch Set 20 : Explicitly depend on librt #

Patch Set 21 : Double check what dlsym thinks the address is. #

Patch Set 22 : make it compile #

Patch Set 23 : printf -> fprintf #

Patch Set 24 : Explicitly link with rt in the events_unittests binary. #

Patch Set 25 : kill the bot with link and compile output. #

Patch Set 26 : Write a test that uses clock_gettime and link it into the binary. #

Patch Set 27 : Maybe the ifdef guards are wrong. #

Patch Set 28 : Update comment to explain what's going on. #

Patch Set 29 : Try one final gn hack. #

Patch Set 30 : OK, the gn hack appears to work. #

Patch Set 31 : Document which flag is causing the issue. #

Patch Set 32 : Bug link #

Patch Set 33 : grammar #

Patch Set 34 : Now just undisable the test now that the fix was rolled in. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M mojo/tools/data/unittests View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Elliot Glaysher
5 years, 11 months ago (2015-01-26 19:10:05 UTC) #2
jamesr
Do you know what flag is actually causing the issue? You should be able to ...
5 years, 11 months ago (2015-01-26 23:41:20 UTC) #3
Elliot Glaysher
On 2015/01/26 23:41:20, jamesr wrote: > Do you know what flag is actually causing the ...
5 years, 11 months ago (2015-01-26 23:54:17 UTC) #4
jamesr
OK, and other targets that use clock_gettime (such as base) are unaffected? Do we know ...
5 years, 11 months ago (2015-01-27 00:01:30 UTC) #5
Elliot Glaysher
ptal. green now that I've rolled chromium deps.
5 years, 10 months ago (2015-01-28 19:00:55 UTC) #6
jamesr
Cool - please update the patch description (there's no hack any more, at least not ...
5 years, 10 months ago (2015-01-28 19:23:49 UTC) #7
jamesr
lgtm
5 years, 10 months ago (2015-01-28 19:23:55 UTC) #8
Elliot Glaysher
5 years, 10 months ago (2015-01-28 20:32:19 UTC) #9
Message was sent while issue was closed. 
Committed patchset #34 (id:600001) manually as
193e68613ff439d2068313eac9c49320f72a61a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698