Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 875513007: IPC Fuzzer: Enable ChannelMojo if it should be enabled. (Closed)

Created:
5 years, 10 months ago by Hajime Morrita
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez, inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IPC Fuzzer: Enable ChannelMojo if it should be enabled. Now Chrome start using ChannelMojo. The ipc_fuzzer has to follow the move. R=tsepez@chromium.org, inferno@chromium.org BUG=453571 Committed: https://chromium.googlesource.com/chromium/src/+/c3ab543bc538dbb1c8ac4d0b212d06db03cb4b48

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M tools/ipc_fuzzer/replay/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M tools/ipc_fuzzer/replay/replay.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/ipc_fuzzer/replay/replay_process.cc View 2 chunks +18 lines, -4 lines 2 comments Download

Messages

Total messages: 13 (3 generated)
Hajime Morrita
5 years, 10 months ago (2015-01-30 19:19:37 UTC) #1
inferno
https://codereview.chromium.org/875513007/diff/1/tools/ipc_fuzzer/replay/replay_process.cc File tools/ipc_fuzzer/replay/replay_process.cc (right): https://codereview.chromium.org/875513007/diff/1/tools/ipc_fuzzer/replay/replay_process.cc#newcode76 tools/ipc_fuzzer/replay/replay_process.cc:76: bool should_use_mojo = process_type == switches::kRendererProcess && We launch ...
5 years, 10 months ago (2015-01-30 19:21:49 UTC) #2
Tom Sepez
LGTM
5 years, 10 months ago (2015-01-30 19:21:50 UTC) #3
Hajime Morrita
On 2015/01/30 19:19:37, morrita wrote: I learned how the fuzzer is started. Hope this works ...
5 years, 10 months ago (2015-01-30 19:21:51 UTC) #4
Hajime Morrita
Woa, thanks for the quick lgtm!
5 years, 10 months ago (2015-01-30 19:22:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875513007/1
5 years, 10 months ago (2015-01-30 19:23:44 UTC) #7
Hajime Morrita
https://codereview.chromium.org/875513007/diff/1/tools/ipc_fuzzer/replay/replay_process.cc File tools/ipc_fuzzer/replay/replay_process.cc (right): https://codereview.chromium.org/875513007/diff/1/tools/ipc_fuzzer/replay/replay_process.cc#newcode76 tools/ipc_fuzzer/replay/replay_process.cc:76: bool should_use_mojo = process_type == switches::kRendererProcess && On 2015/01/30 ...
5 years, 10 months ago (2015-01-30 19:29:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875513007/1
5 years, 10 months ago (2015-01-30 19:30:38 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c3ab543bc538dbb1c8ac4d0b212d06db03cb4b48 Cr-Commit-Position: refs/heads/master@{#313962}
5 years, 10 months ago (2015-01-30 19:33:55 UTC) #12
Hajime Morrita
5 years, 10 months ago (2015-01-30 19:34:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c3ab543bc538dbb1c8ac4d0b212d06db03cb4b48 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698